| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Notes: I couldn't reproduce the original anymore, so I don't know how we can confirm this will actually work? |
Sorry, something went wrong.
|
Good point. I'll see if I can spin up a vm and try to reproduce |
Sorry, something went wrong.
There was a problem hiding this comment.
why are we doing a cd followed by rm and not rm with absolute path?
Sorry, something went wrong.
There was a problem hiding this comment.
wow, good question. That is how the postinstall script is done. And now that I look again, it was done that way for a reason. Updating now
Sorry, something went wrong.
There was a problem hiding this comment.
maybe we also need a set -e if we're doing multiple lines, if the cd fails then the rm will still execute
Sorry, something went wrong.
Make sure we cleanly remove npm before installing on OS X
|
Ok, updated with absolute path and set -e |
Sorry, something went wrong.
|
test build of this created @ https://nodejs.org/download/test/v6.0.0-test201512088ac2af7628/ if anyone else wants to review the changes |
Sorry, something went wrong.
|
I touched a bunch of TEST files under /usr/local/lib before running the installer and they still exist: $ node -v v6.0.0-test201512088ac2af7628 $ find /usr/local -name TEST /usr/local/lib/node_modules/npm/node_modules/TEST /usr/local/lib/node_modules/npm/TEST /usr/local/lib/node_modules/TEST /usr/local/lib/TEST So something's not right with this as far as I can tell. |
Sorry, something went wrong.
|
Perhaps it needs to be "preupgrade" as well as "preinstall". Reading here http://s.sudre.free.fr/Stuff/PackageMaker_Howto.html but I don't know how authoritative this is. |
Sorry, something went wrong.
|
@rvagg Ok yes it looks like neither the preinstall, nor the postinstall scripts were running. What is weird to me is that the local.pkg installs npm, so there really is no need to have an npm.pkg. Even if one deselects the npm choice, npm will still be installed. I can make it a single package and then the scripts work properly. I guess my question becomes, is it worth it? With how outdated PackageMaker.app is, I really think that we should try to get #2571 landed. Is there anything blocking that? |
Sorry, something went wrong.
|
@evanlucas I think the other issue mostly needs review. |
Sorry, something went wrong.
|
Closing. Hopefully we can get the new OS X pkg stuff in soon. It should replace this anyways |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Make sure we cleanly remove npm before installing on OS X
Related: #3606
This is working for me locally, but would be great to have some others test.