| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Co-authored-by: James M Snell <jasnell@gmail.com>
Co-authored-by: James M Snell <jasnell@gmail.com>
| * @param {{ | ||
| * encoding?: string; | ||
| * autoClose?: boolean; | ||
| * emitClose?: boolean; |
There was a problem hiding this comment.
Can we remove autoClose & emitClose from here?
Sorry, something went wrong.
There was a problem hiding this comment.
Could you explain why?
Sorry, something went wrong.
There was a problem hiding this comment.
They are legacy. The only reason we have still have them is to avoid breakage. Since this is a new API they are not necessary.
Sorry, something went wrong.
There was a problem hiding this comment.
It’s a new way for exposing the same old API, removing it would be harder than keeping it – also I don’t think they’re documented as legacy anywhere, so that’s probably best to leave that discussion for another PR.
Sorry, something went wrong.
| * @param {{ | ||
| * encoding?: string; | ||
| * autoClose?: boolean; | ||
| * emitClose?: boolean; |
There was a problem hiding this comment.
Can we remove autoClose & emitClose from here?
Sorry, something went wrong.
Sorry, something went wrong.
|
/cc @nodejs/fs |
Sorry, something went wrong.
PR-URL: #40009 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #40009 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@aduh95 do you mind opening a backport PR to v16.x-staging? The PR broke the lint-js script. Thanks! |
Sorry, something went wrong.
PR-URL: nodejs#40009 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
| Back | FazBrowse Home | New Git URL |
Adding filehandle.createReadStream and filehandle.createWriteStream methods to FileHandle class. This is useful to be able create ReadStream or WriteStream from fs/promises.
It also accept the same functions as fs.createReadStream and fs.createWriteStream respectively: