FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v16.x backport] fs: add stream utilities to `FileHandle` by aduh95 · Pull Request #40329 · nodejs/node · GitHub

/ node Public

[v16.x backport] fs: add stream utilities to FileHandle - #40329

Closed
aduh95 wants to merge 1 commit into
nodejs:v16.x-stagingfrom
aduh95:fs-promises-fh-nodejs-streams-v16
ConversationCommits (1)ChecksFiles changed
Closed

[v16.x backport] fs: add stream utilities to FileHandle#40329
aduh95 wants to merge 1 commit into
nodejs:v16.x-stagingfrom
aduh95:fs-promises-fh-nodejs-streams-v16

Conversation

aduh95 commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

PR-URL: #40009
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. v16.x labels Oct 5, 2021
aduh95 mentioned this pull request Oct 6, 2021
Merged
danielleadams added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 6, 2021

github-actions Bot commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @danielleadams. Please 👍 to approve.

nodejs-github-bot commented Oct 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40182/

fs: add stream utilities to FileHandle
4b3aef2 
PR-URL: nodejs#40009
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 force-pushed the fs-promises-fh-nodejs-streams-v16 branch from deaed50 to 4b3aef2 Compare October 6, 2021 21:39

nodejs-github-bot commented Oct 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40184/

nodejs-github-bot commented Oct 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40186/

github-actions Bot mentioned this pull request Oct 7, 2021
Open
25 tasks

nodejs-github-bot commented Oct 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40188/

danielleadams commented Oct 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Build issues are fixed here: #40296, so going to go ahead and land. That fixes another build issue - windows-fanned looks still broken.

danielleadams commented Oct 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Landed in c7f3294

danielleadams pushed a commit that referenced this pull request Oct 7, 2021
fs: add stream utilities to FileHandle
c7f3294 
PR-URL: #40009
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: #40329
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
aduh95 closed this Oct 7, 2021
aduh95 deleted the fs-promises-fh-nodejs-streams-v16 branch October 7, 2021 06:38
This was referenced Oct 8, 2021
Open
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
danielleadams danielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL