src: get embedder options on-demand - #40357
Closed
joyeecheung wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Only query embedder options when they are needed so that the bootstrap remains as stateless as possible so that the bootstrap snapshot is controlled solely by configure options, and subsequent runtime changes should be done in pre-execution.
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/embedders |
Sorry, something went wrong.
addaleax
approved these changes
Oct 7, 2021
Comment thread
src/node_options.cc
Outdated
jasnell
approved these changes
Oct 7, 2021
codebytere
approved these changes
Oct 7, 2021
Co-authored-by: Anna Henningsen <github@addaleax.net>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
22 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
There are intermittent timeouts on arm builds with test-crypto-dh and test-crypto-binary-default, though I can't tell how this PR could be related to these two tests. My guess is that the arm bots are not powerful enough and the tests are putting too many computation-intensive cases into single files. I'll see if splitting the test cases out helps. |
Sorry, something went wrong.
This was referenced Oct 14, 2021
joyeecheung
added a commit
that referenced
this pull request
Oct 16, 2021
Only query embedder options when they are needed so that the bootstrap remains as stateless as possible so that the bootstrap snapshot is controlled solely by configure options, and subsequent runtime changes should be done in pre-execution. PR-URL: #40357 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
Copy link
Copy Markdown
Member
Author
|
Tests were green. Landed in 38aa7cc |
Sorry, something went wrong.
This was referenced Oct 17, 2021
2 tasks
25 tasks
targos
pushed a commit
that referenced
this pull request
Nov 4, 2021
Only query embedder options when they are needed so that the bootstrap remains as stateless as possible so that the bootstrap snapshot is controlled solely by configure options, and subsequent runtime changes should be done in pre-execution. PR-URL: #40357 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only query embedder options when they are needed so that the bootstrap
remains as stateless as possible so that the bootstrap snapshot is
controlled solely by configure options, and subsequent runtime changes
should be done in pre-execution.