FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: add more filter tests by benjamingr · Pull Request #41936 · nodejs/node · GitHub

/ node Public

stream: add more filter tests - #41936

Closed
benjamingr wants to merge 3 commits into
nodejs:masterfrom
benjamingr:add-filter-tests
Closed

stream: add more filter tests#41936
benjamingr wants to merge 3 commits into
nodejs:masterfrom
benjamingr:add-filter-tests

Conversation

Copy link
Copy Markdown
Member

Add more tests to Readable.prototype.filter

cc @nodejs/streams @aduh95

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 11, 2022
benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2022

Copy link
Copy Markdown
Collaborator

});
assert.rejects(
stream.filter(() => true).toArray(),
/boom/,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we would want to check the error by reference here, to match the spec proposal text.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I recall this discussion before but I don't recall the conclusion, do you happen to have a reference?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

aduh95 commented Feb 13, 2022

Copy link
Copy Markdown
Contributor

There's a CI failure related to the changes in this PR:

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

4 !== 2

    at Immediate._onImmediate (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-stream-filter.js:136:12)
    at processImmediate (node:internal/timers:466:21) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 4,
  expected: 2,
  operator: 'strictEqual'
}

Copy link
Copy Markdown
Member Author

@aduh95 that's actually not related to this PR - but I can see why that'd happen I'll push a fix (which again is unrelated to this PR).

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 14, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 14, 2022

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

benjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 14, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 14, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/41936
✔  Done loading data for nodejs/node/pull/41936
----------------------------------- PR info ------------------------------------
Title      stream: add more filter tests (#41936)
Author     Benjamin Gruenbaum  (@benjamingr)
Branch     benjamingr:add-filter-tests -> nodejs:master
Labels     test, needs-ci
Commits    3
 - stream: add more filter tests
 - fixup!
 - fixup! remove timeout from test
Committers 1
 - Benjamin Gruenbaum 
PR-URL: https://github.com/nodejs/node/pull/41936
Reviewed-By: Robert Nagy 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41936
Reviewed-By: Robert Nagy 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - fixup! remove timeout from test
   ℹ  This PR was created on Fri, 11 Feb 2022 17:55:59 GMT
   ✔  Approvals: 3
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/41936#pullrequestreview-880871183
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41936#pullrequestreview-880872056
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41936#pullrequestreview-880887559
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-02-14T14:26:06Z: https://ci.nodejs.org/job/node-test-pull-request/42554/
- Querying data for job/node-test-pull-request/42554/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1842083455

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 14, 2022
benjamingr added a commit that referenced this pull request Feb 14, 2022
PR-URL: #41936
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Copy link
Copy Markdown
Member Author

Forgot to autosquash, meh, landed manually :)

Landed in da11381 🎉

benjamingr closed this Feb 14, 2022

aduh95 commented Feb 14, 2022

Copy link
Copy Markdown
Contributor

Forgot to autosquash, meh

FYI you can use commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. to ask the CQ to squash all the commits when landing a PR.

Copy link
Copy Markdown
Member Author

Thanks, yeah, I forgot to use that and already had a terminal open with node so I just landed with ncu :)

bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
PR-URL: nodejs#41936
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bengl pushed a commit to bengl/node that referenced this pull request Feb 21, 2022
PR-URL: nodejs#41936
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bengl mentioned this pull request Feb 21, 2022
bengl pushed a commit that referenced this pull request Feb 21, 2022
PR-URL: #41936
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bengl pushed a commit that referenced this pull request Feb 22, 2022
PR-URL: #41936
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Copy link
Copy Markdown
Contributor

@benjamingr this breaks when landing on v16.x-staging. Can you open a backport PR to land on v16.x? Thank you

targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #41936
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#41936
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL