| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
| }); | ||
| assert.rejects( | ||
| stream.filter(() => true).toArray(), | ||
| /boom/, |
There was a problem hiding this comment.
I think we would want to check the error by reference here, to match the spec proposal text.
Sorry, something went wrong.
There was a problem hiding this comment.
I recall this discussion before but I don't recall the conclusion, do you happen to have a reference?
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
|
There's a CI failure related to the changes in this PR: AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
4 !== 2
at Immediate._onImmediate (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-stream-filter.js:136:12)
at processImmediate (node:internal/timers:466:21) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: 4,
expected: 2,
operator: 'strictEqual'
}
|
Sorry, something went wrong.
|
@aduh95 that's actually not related to this PR - but I can see why that'd happen I'll push a fix (which again is unrelated to this PR). |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Commit Queue failed- Loading data for nodejs/node/pull/41936 ✔ Done loading data for nodejs/node/pull/41936 ----------------------------------- PR info ------------------------------------ Title stream: add more filter tests (#41936) Author Benjamin Gruenbaum (@benjamingr) Branch benjamingr:add-filter-tests -> nodejs:master Labels test, needs-ci Commits 3 - stream: add more filter tests - fixup! - fixup! remove timeout from test Committers 1 - Benjamin Gruenbaum PR-URL: https://github.com/nodejs/node/pull/41936 Reviewed-By: Robert Nagy Reviewed-By: James M Snell Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41936 Reviewed-By: Robert Nagy Reviewed-By: James M Snell Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup! remove timeout from test ℹ This PR was created on Fri, 11 Feb 2022 17:55:59 GMT ✔ Approvals: 3 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/41936#pullrequestreview-880871183 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41936#pullrequestreview-880872056 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41936#pullrequestreview-880887559 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-02-14T14:26:06Z: https://ci.nodejs.org/job/node-test-pull-request/42554/ - Querying data for job/node-test-pull-request/42554/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1842083455 |
Sorry, something went wrong.
PR-URL: #41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
Forgot to autosquash, meh, landed manually :) Landed in da11381 🎉 |
Sorry, something went wrong.
FYI you can use commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. to ask the CQ to squash all the commits when landing a PR. |
Sorry, something went wrong.
|
Thanks, yeah, I forgot to use that and already had a terminal open with node so I just landed with ncu :) |
Sorry, something went wrong.
PR-URL: nodejs#41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: nodejs#41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
@benjamingr this breaks when landing on v16.x-staging. Can you open a backport PR to land on v16.x? Thank you |
Sorry, something went wrong.
PR-URL: #41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: nodejs/node#41936 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
| Back | FazBrowse Home | New Git URL |
Add more tests to Readable.prototype.filter
cc @nodejs/streams @aduh95