| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
PR-URL: #41925 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
1. Any keystroke emits `0x1E` will do redo action. 2. Fix bug of undo/redo. 3. More detailed document. 4. Unit tests. PR-URL: #41662 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #41791 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fixes: #41633 Fixes: #40958 - move test-crypto-engine so that dummy engine is only built if tests are run Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41830 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Deprecate the process multipleResolves event to detect when a promise is resolved more than once because it never really worked. Fixes: #41554 PR-URL: #41872 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #41892 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
replacable -> replaceable PR-URL: #41891 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
The ellipsis in `All together` is not needed. I've had it on my list of "small things to take care of when you get a chance" for a while. The Microsoft Style Guide says to not use ellipses except in certain cases, and that reminded me to do it. The day has arrived! PR-URL: #41888 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
There are a few places in lib where `new Error()` is called and then additional properties are attached in various ways. This creates a utility function to generate the errors. PR-URL: #41879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com> Co-authored-by: James M Snell <jasnell@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com> Co-authored-by: James Sumners <james@sumners.email> PR-URL: #36328 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: #41889 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #41623 Co-authored-by: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
With the introduction of the promises API for setTimeout(), the requirement that it have two parameters may not be sensible anymore in tests. PR-URL: #41901 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
I added support for x32 back in 2014 but it's been in a state of disrepair ever since, not in the least because it was never a fully supported architecture in upstream V8. V8 dropped x32 support entirely in or around 2018 so the removal from Node's build system is long overdue. Refs: #40576 PR-URL: #41905 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
An interface with index 0 doesn't make sense and makes `if_indextoname()` to return `ENXIO` which crashes the process. Fixes: #41500 PR-URL: #41547 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Review requested:
|
Sorry, something went wrong.
Notable changes: * [bdbe655] - doc: add marsonya to collaborators (Akhil Marsonya) #41991 * [8fe8dee] - doc: deprecate notice for process methods (Yash Ladha) #41587 * [abd6967] - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 * [b968d89] - build: remove broken x32 arch support (Ben Noordhuis) #41905 * [ba639d0] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 * [0de611f] - doc: add joesepi to collaborators (Joe Sepi) #41914 * [5796c3a] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 PR-URL: #42072
|
|
||
| <a id="17.6.0"></a> | ||
|
|
||
| ## 2022-02-22, Version 17.6.0 (Current), @bengl |
There was a problem hiding this comment.
Previously we've done a @releaser prepared by @potential-new-releaser format, e.g.:
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#2020-10-07-version-14131-current-bethgriggs-prepared-by-danielleadams
| ## 2022-02-22, Version 17.6.0 (Current), @bengl | |
| ## 2022-02-22, Version 17.6.0 (Current), @BethGriggs prepared by @bengl |
Sorry, something went wrong.
|
The commit message should not contain the releaser's handle. |
Sorry, something went wrong.
This adds more globals to the set known by ESLint. PR-URL: #42043 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #42057 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
From the #nodejs-release Slack thread it looks like these tests were introduced by #41818. Complicating things is that after nodejs/build#2837 (comment) we're no longer running x64 debug builds on master -- instead we're running debug builds on arm64. There was some allusion to flakiness in #41818 (review) which links through to #41204 which mentions that the crash went away in a V8 update which is not likely to land on v17.x. We probably want to hold off landing #41818 on v17.x-staging for now. |
Sorry, something went wrong.
Notable changes: - doc: deprecate notice for process methods (Yash Ladha) #41587 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 - build: remove broken x32 arch support (Ben Noordhuis) #41905 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662 - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 - Documentation-only. Dependency updates: - deps: upgrade npm to 8.5.1 (npm-robot) #42039 - deps: update undici to 3e267ece5f (Michaël Zasso) #41955 - deps: upgrade npm to 8.5.0 (npm-robot) #41925 New collaborators: - doc: add marsonya to collaborators (Akhil Marsonya) #41991 - doc: add joesepi to collaborators (Joe Sepi) #41914 PR-URL: #42072
|
New CI: https://ci.nodejs.org/job/node-test-pull-request/42724/ |
Sorry, something went wrong.
Sorry, something went wrong.
|
Release build on 39ae944: https://ci-release.nodejs.org/job/iojs+release/8265 |
Sorry, something went wrong.
| * \[[`297d217efc`](https://github.com/nodejs/node/commit/297d217efc)] - **tools**: reduce list of globals in ESLint config (Rich Trott) [#41996](https://github.com/nodejs/node/pull/41996) | ||
| * \[[`916cda4afc`](https://github.com/nodejs/node/commit/916cda4afc)] - **tools**: update remark-preset-lint-node to 3.3.1 (Rich Trott) [#41999](https://github.com/nodejs/node/pull/41999) | ||
| * \[[`7a72aa776a`](https://github.com/nodejs/node/commit/7a72aa776a)] - **tools**: update ESLint to 8.9.0 (Luigi Pinca) [#41973](https://github.com/nodejs/node/pull/41973) | ||
| * \[[`0c4977cf29`](https://github.com/nodejs/node/commit/0c4977cf29)] - **tools**: update lint-md-dependencies to rollup\@2.67.2 (Node.js GitHub Bot) [#41941](https://github.com/nodejs/node/pull/41941) |
There was a problem hiding this comment.
I haven't checked all of them, but it looks like there's a mismatch to the commit shas on the actual branch, most probably due to one of the rebases.
Sorry, something went wrong.
There was a problem hiding this comment.
Fixed in latest push.
Sorry, something went wrong.
There was a problem hiding this comment.
| * \[[`326f54576a`](https://github.com/nodejs/node/commit/326f54576a)] - **doc**: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587) | |
| * \[[`6b88595142`](https://github.com/nodejs/node/commit/6b88595142)] - **doc**: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587) |
Sorry, something went wrong.
There was a problem hiding this comment.
| * \[[`abd6967153`](https://github.com/nodejs/node/commit/abd6967153)] - **stream**: revert `map` spec compliance (Benjamin Gruenbaum) [#41931](https://github.com/nodejs/node/pull/41931) | |
| * \[[`77462b6083`](https://github.com/nodejs/node/commit/77462b6083)] - **stream**: revert `map` spec compliance (Benjamin Gruenbaum) [#41931](https://github.com/nodejs/node/pull/41931) |
Sorry, something went wrong.
There was a problem hiding this comment.
| * \[[`88cbceb3ca`](https://github.com/nodejs/node/commit/88cbceb3ca)] - **(SEMVER-MINOR)** **crypto**: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938) | |
| * \[[`60682917dd`](https://github.com/nodejs/node/commit/60682917dd)] - **(SEMVER-MINOR)** **crypto**: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938) |
Sorry, something went wrong.
There was a problem hiding this comment.
| * \[[`1e862b3816`](https://github.com/nodejs/node/commit/1e862b3816)] - **(SEMVER-MINOR)** **fs**: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](https://github.com/nodejs/node/pull/41819) | |
| * \[[`214d17650b`](https://github.com/nodejs/node/commit/214d17650b)] - **(SEMVER-MINOR)** **fs**: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](https://github.com/nodejs/node/pull/41819) |
Sorry, something went wrong.
There was a problem hiding this comment.
| * \[[`4fbe064ce0`](https://github.com/nodejs/node/commit/4fbe064ce0)] - **(SEMVER-MINOR)** **lib**: add FormData global when fetch is enabled (Michaël Zasso) [#41956](https://github.com/nodejs/node/pull/41956) | |
| * \[[`ec0d623bd7`](https://github.com/nodejs/node/commit/ec0d623bd7)] - **(SEMVER-MINOR)** **lib**: add FormData global when fetch is enabled (Michaël Zasso) [#41956](https://github.com/nodejs/node/pull/41956) |
Sorry, something went wrong.
There was a problem hiding this comment.
| * \[[`811f04bd34`](https://github.com/nodejs/node/commit/811f04bd34)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](https://github.com/nodejs/node/pull/42039) | |
| * \[[`d1ef43f2aa`](https://github.com/nodejs/node/commit/d1ef43f2aa)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](https://github.com/nodejs/node/pull/42039) |
Sorry, something went wrong.
There was a problem hiding this comment.
| * \[[`605271ba8c`](https://github.com/nodejs/node/commit/605271ba8c)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](https://github.com/nodejs/node/pull/41955) | |
| * \[[`09c17481f6`](https://github.com/nodejs/node/commit/09c17481f6)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](https://github.com/nodejs/node/pull/41955) |
Sorry, something went wrong.
There was a problem hiding this comment.
| * \[[`7c19c7496e`](https://github.com/nodejs/node/commit/7c19c7496e)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](https://github.com/nodejs/node/pull/41991) | |
| * \[[`90d90e3868`](https://github.com/nodejs/node/commit/90d90e3868)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](https://github.com/nodejs/node/pull/41991) |
Sorry, something went wrong.
Notable changes: - doc: deprecate notice for process methods (Yash Ladha) #41587 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 - build: remove broken x32 arch support (Ben Noordhuis) #41905 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662 - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 - Documentation-only. Dependency updates: - deps: upgrade npm to 8.5.1 (npm-robot) #42039 - deps: update undici to 3e267ece5f (Michaël Zasso) #41955 - deps: upgrade npm to 8.5.0 (npm-robot) #41925 New collaborators: - doc: add marsonya to collaborators (Akhil Marsonya) #41991 - doc: add joesepi to collaborators (Joe Sepi) #41914 PR-URL: #42072
|
@richardlau I'm pretty sure I've fixed all of those now, but my work should certainly be checked 😄 . |
Sorry, something went wrong.
Notable changes: - doc: deprecate notice for process methods (Yash Ladha) #41587 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 - build: remove broken x32 arch support (Ben Noordhuis) #41905 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662 - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 - Documentation-only. Dependency updates: - deps: upgrade npm to 8.5.1 (npm-robot) #42039 - deps: update undici to 3e267ece5f (Michaël Zasso) #41955 - deps: upgrade npm to 8.5.0 (npm-robot) #41925 New collaborators: - doc: add marsonya to collaborators (Akhil Marsonya) #41991 - doc: add joesepi to collaborators (Joe Sepi) #41914 PR-URL: #42072
Notable changes: - doc: deprecate notice for process methods (Yash Ladha) #41587 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 - build: remove broken x32 arch support (Ben Noordhuis) #41905 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662 - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 - Documentation-only. Dependency updates: - deps: upgrade npm to 8.5.1 (npm-robot) #42039 - deps: update undici to 3e267ece5f (Michaël Zasso) #41955 - deps: upgrade npm to 8.5.0 (npm-robot) #41925 New collaborators: - doc: add marsonya to collaborators (Akhil Marsonya) #41991 - doc: add joesepi to collaborators (Joe Sepi) #41914 PR-URL: #42072
| Back | FazBrowse Home | New Git URL |
2022-02-22, Version 17.6.0 (Current), @BethGriggs prepared by @bengl
Notable Changes
Dependency Updates
New Collaborators
Commits