FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v16.x] src,doc,test: add --openssl-shared-config option by RafaelGSS · Pull Request #43783 · nodejs/node · GitHub

/ node Public

[v16.x] src,doc,test: add --openssl-shared-config option - #43783

Closed
RafaelGSS wants to merge 1 commit into
nodejs:v16.x-stagingfrom
RafaelGSS:backport-43124-v16-cli
ConversationCommits (1)ChecksFiles changed
Closed

[v16.x] src,doc,test: add --openssl-shared-config option#43783
RafaelGSS wants to merge 1 commit into
nodejs:v16.x-stagingfrom
RafaelGSS:backport-43124-v16-cli

Conversation

RafaelGSS commented Jul 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

This was forgotten in: #43545
Ref: nodejs/nodejs.org#4713

This commit adds a new command line option named
'--openssl-shared-config' intended to allow reverting to the old OpenSSL
configuration behavior where Node.js would use the configuration section
name (called appname in OpenSSL) 'openssl_conf' which could potentially
be used my other applications..

PR-URL: #43124
Refs: #40366
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Beth Griggs bgriggs@redhat.com

RafaelGSS requested a review from danbev July 11, 2022 18:54

nodejs-github-bot commented Jul 11, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v16.x labels Jul 11, 2022
src,doc,test: add --openssl-shared-config option
ecdead2 
This commit adds a new command line option named
'--openssl-shared-config' intended to allow reverting to the old OpenSSL
configuration behavior where Node.js would use the configuration section
name (called appname in OpenSSL) 'openssl_conf' which could potentially
be used my other applications..

PR-URL: nodejs#43124
Refs: nodejs#40366
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
RafaelGSS force-pushed the backport-43124-v16-cli branch from 7399ebe to ecdead2 Compare July 12, 2022 16:44
mcollina approved these changes Jul 12, 2022
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 13, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 13, 2022

nodejs-github-bot commented Jul 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45392/

nodejs-github-bot commented Jul 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45405/

github-actions Bot mentioned this pull request Jul 14, 2022
Open
29 tasks

nodejs-github-bot commented Jul 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45435/

github-actions Bot mentioned this pull request Jul 15, 2022
Open
24 tasks

nodejs-github-bot commented Jul 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45451/

nodejs-github-bot commented Jul 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45458/

nodejs-github-bot commented Jul 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45462/

nodejs-github-bot commented Jul 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45464/

nodejs-github-bot commented Jul 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45467/

nodejs-github-bot commented Jul 16, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45475/

targos commented Jul 18, 2022

Copy link
Copy Markdown
Member

I'm sorry, there is now a conflict with other commits that landed on v16.x-staging. Could you please update the backport?
The original commit now lands cleanly but there's a compiler error:

../../src/node.cc:1102:35: error: no member named 'openssl_shared_config' in 'node::PerProcessOptions'; did you mean 'openssl_config'?
    if (per_process::cli_options->openssl_shared_config) {
                                  ^~~~~~~~~~~~~~~~~~~~~
                                  openssl_config
../../src/node_options.h:246:15: note: 'openssl_config' declared here
  std::string openssl_config;
              ^
1 error generated

I noted that in the original change, the flag only exists if node is compiled with OpenSSL 3 but that's not the case with this PR. Is that intended?

RafaelGSS commented Jul 18, 2022

Copy link
Copy Markdown
Member Author

I noted that in the original change, the flag only exists if node is compiled with OpenSSL 3 but that's not the case with this PR. Is that intended?

Yes, it was added this way because the initial idea was to support v17.x > only, but we need the revert flag in other release lines as well.

Thanks for notifying me, I'll rebase

RafaelGSS commented Jul 18, 2022

Copy link
Copy Markdown
Member Author

Closing in favor of: #43892. Sorry, due to many conflicts was better to create a new fresh PR.

RafaelGSS closed this Jul 18, 2022
This was referenced Jul 19, 2022
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
richardlau richardlau approved these changes
BethGriggs BethGriggs approved these changes
danbev Awaiting requested review from danbev

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL