[v16.x] src,doc,test: add --openssl-shared-config option - #43892
Closed
RafaelGSS wants to merge 1 commit into
Closed
[v16.x] src,doc,test: add --openssl-shared-config option#43892RafaelGSS wants to merge 1 commit into
RafaelGSS wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
targos
reviewed
Jul 18, 2022
Comment thread
test/parallel/test-process-env-allowed-flags-are-documented.js
Outdated
This commit adds a new command line option named '--openssl-shared-config' intended to allow reverting to the old OpenSSL configuration behavior where Node.js would use the configuration section name (called appname in OpenSSL) 'openssl_conf' which could potentially be used my other applications.. PR-URL: nodejs#43124 Refs: nodejs#40366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Backport-PR: nodejs#43892
RafaelGSS
force-pushed
the
backport-43124-v16-cli-opt
branch
from
13e425e to
ab0313d
Compare
July 18, 2022 16:23
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
approved these changes
Jul 19, 2022
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
16 tasks
targos
approved these changes
Jul 20, 2022
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
This commit adds a new command line option named '--openssl-shared-config' intended to allow reverting to the old OpenSSL configuration behavior where Node.js would use the configuration section name (called appname in OpenSSL) 'openssl_conf' which could potentially be used my other applications.. PR-URL: #43124 Backport-PR-URL: #43892 Refs: #40366 Refs: nodejs/nodejs.org#4713 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
This was referenced Jul 21, 2022
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This commit adds a new command line option named '--openssl-shared-config' intended to allow reverting to the old OpenSSL configuration behavior where Node.js would use the configuration section name (called appname in OpenSSL) 'openssl_conf' which could potentially be used my other applications.. PR-URL: #43124 Backport-PR-URL: #43892 Refs: #40366 Refs: nodejs/nodejs.org#4713 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This commit adds a new command line option named '--openssl-shared-config' intended to allow reverting to the old OpenSSL configuration behavior where Node.js would use the configuration section name (called appname in OpenSSL) 'openssl_conf' which could potentially be used my other applications.. PR-URL: nodejs/node#43124 Backport-PR-URL: nodejs/node#43892 Refs: nodejs/node#40366 Refs: nodejs/nodejs.org#4713 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was forgotten in: #43545
Ref: nodejs/nodejs.org#4713
This commit adds a new command line option named
'--openssl-shared-config' intended to allow reverting to the old OpenSSL
configuration behavior where Node.js would use the configuration section
name (called appname in OpenSSL) 'openssl_conf' which could potentially
be used my other applications..
PR-URL: #43124
Refs: #40366
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Beth Griggs bgriggs@redhat.com