FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix bug in GetErrorSource() by tniessen · Pull Request #44019 · nodejs/node · GitHub

/ node Public

src: fix bug in GetErrorSource() - #44019

Closed
tniessen wants to merge 1 commit into
nodejs:mainfrom
tniessen:src-errors-fix-geterrorsource
ConversationCommits (1)ChecksFiles changed
Closed

src: fix bug in GetErrorSource()#44019
tniessen wants to merge 1 commit into
nodejs:mainfrom
tniessen:src-errors-fix-geterrorsource

Conversation

tniessen commented Jul 28, 2022

Copy link
Copy Markdown
Member

Reported by static analysis. I assume this was supposed to dereference the bool*.

There does not seem to be a test covering (*added_exception_line) == false and I'm not familiar enough with this part of the code base to come up with one quickly.

Refs: #43875

tniessen requested a review from legendecas July 28, 2022 08:18
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 28, 2022
tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2022
tniessen requested a review from bcoe July 28, 2022 08:54
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2022

nodejs-github-bot commented Jul 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45717/

legendecas approved these changes Jul 28, 2022
View reviewed changes

legendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for catching this! I'll come up with a test case later today.

tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2022

nodejs-github-bot commented Jul 29, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45731/

tniessen added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 29, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2022

This comment was marked as outdated.

Sign in to view
nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 29, 2022
tniessen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 29, 2022
tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2022

legendecas commented Jul 30, 2022

Copy link
Copy Markdown
Member

Landed in f2afcad

legendecas pushed a commit that referenced this pull request Jul 30, 2022
src: fix bug in GetErrorSource()
f2afcad 
Refs: #43875

PR-URL: #44019
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
legendecas closed this Jul 30, 2022
tniessen removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2022
legendecas mentioned this pull request Jul 30, 2022
Closed
legendecas added a commit that referenced this pull request Aug 6, 2022
src,lib: print prinstine source when source map source not found
0a2c910 
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.

PR-URL: #44052
Refs: #44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
src: fix bug in GetErrorSource()
6343e1d 
Refs: #43875

PR-URL: #44019
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
src,lib: print prinstine source when source map source not found
63b5c49 
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.

PR-URL: #44052
Refs: #44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
danielleadams mentioned this pull request Aug 16, 2022
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
src: fix bug in GetErrorSource()
b90b8ab 
Refs: #43875

PR-URL: #44019
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
src,lib: print prinstine source when source map source not found
ee6412a 
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.

PR-URL: #44052
Refs: #44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
ruyadorno mentioned this pull request Aug 23, 2022
Merged

targos commented Sep 16, 2022

Copy link
Copy Markdown
Member

Depends on #43875

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
richardlau richardlau approved these changes
legendecas legendecas approved these changes
bcoe Awaiting requested review from bcoe
+1 more reviewer
F3n67u F3n67u approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL