src,lib: print prinstine source when source map source not found - #44052
Closed
legendecas wants to merge 1 commit into
Closed
src,lib: print prinstine source when source map source not found#44052legendecas wants to merge 1 commit into
legendecas wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
legendecas
marked this pull request as ready for review
July 30, 2022 08:36
legendecas
force-pushed
the
test-error-source
branch
from
9beec4f to
4fde82c
Compare
July 30, 2022 08:42
bcoe
approved these changes
Aug 3, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
commented
Aug 4, 2022
Comment thread
lib/internal/source_map/prepare_stack_trace.js
Comment on lines
+149
to
+151
| if (typeof source !== 'string') { | ||
| return; | ||
| } |
This comment was marked as outdated.
Copy link
Copy Markdown
Member
|
This depends on #43875 to be landed in v16.x |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print unmapped source lines when the source map source is not found. Error stacks should be correctly mapped even when the source is absent.
Refs: #44019