build: add support for native Windows ARM64 MSVC - #44226
Closed
dennisameling wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
joyeecheung
approved these changes
Aug 15, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Aug 16, 2022
lpinca
self-requested a review
August 16, 2022 18:22
lpinca
approved these changes
Aug 16, 2022
lpinca
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
jasnell
approved these changes
Aug 28, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Nov 2, 2022
Visual Studio 2022 17.4 introduces native ARM64 support, including host tools for MSVC. As this won't be supported on VS2019, this commit only adds the detection logic for native ARM64 tools to vs-set-2022. Refs: nodejs/build#2540 Refs: https://devblogs.microsoft.com/visualstudio/arm64-visual-studio/
Copy link
Copy Markdown
Contributor
Author
|
Now that #46228 has been merged, this seems to be the right time to merge this PR too. Just rebased it and ran it on an arm64 device. The build finished successfully and used the native VS2022 arm64 build tools: PS C:\repos\node> ./vcbuild.bat arm64 release Looking for Python Python found in C:\Program Files\Python311-arm64\\python.exe Python 3.11.0rc1 Looking for Visual Studio 2022 calling: "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\\Auxiliary\Build\vcvarsall.bat" arm64 ********************************************************************** ** Visual Studio 2022 Developer Command Prompt v17.4.4 ** Copyright (c) 2022 Microsoft Corporation ********************************************************************** [vcvarsall.bat] Environment initialized for: 'arm64' Found MSVS version 17.0 configure --with-ltcg --dest-cpu=arm64 Node.js configure: Found Python 3.11.0... .... node.vcxproj -> out\Release\\node.exe Junction created for Release <<===>> out\Release Creating package... Creating node-v20.0.0-win-arm64.7z Creating node-v20.0.0-win-arm64.zip Creating node_pdb.7z Creating node_pdb.zip Package created! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Superseded by #46420 which just got merged 👍🏼 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual Studio 2022 17.4 introduces native ARM64 support, including host tools for MSVC. As this won't be supported on VS2019, this commit only adds the detection logic for native ARM64 tools to vs-set-2022.
Refs: nodejs/build#2540
Refs: https://devblogs.microsoft.com/visualstudio/arm64-visual-studio/