FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Visual Studio installation detection for Arm64 by Blackhex · Pull Request #46420 · nodejs/node · GitHub

/ node Public

Fix Visual Studio installation detection for Arm64 - #46420

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Windows-on-ARM-Experiments:fix-vswhere-arm64
Mar 2, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Fix Visual Studio installation detection for Arm64#46420
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Windows-on-ARM-Experiments:fix-vswhere-arm64

Conversation

Blackhex commented Jan 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

When vcbuild.bat arm64 was run on Windows Arm64 machine, the vswhere_usability_wrapper.cmd was detecting proper installation of Visual Studio according to presence of x64 Build Tools which fails when there is only Arm64 version of the Build Tools.

nodejs-github-bot added build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Jan 30, 2023
Blackhex force-pushed the fix-vswhere-arm64 branch 5 times, most recently from 3aca22a to 446769c Compare January 31, 2023 10:06

bnoordhuis commented Jan 31, 2023

Copy link
Copy Markdown
Member

@nodejs/platform-windows-arm

Blackhex force-pushed the fix-vswhere-arm64 branch 3 times, most recently from 970358a to d0517b9 Compare February 3, 2023 12:24
StefanStojanovic requested changes Feb 3, 2023
View reviewed changes

StefanStojanovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These changes break building on Windows x64.

Comment thread vcbuild.bat Outdated

StefanStojanovic Feb 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This fails on Windows x64, since it compares "x64" to "amd64"

Blackhex Feb 5, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

OK, thank you. Let me fix that.

Blackhex Feb 5, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should be fixed now.

StefanStojanovic Feb 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry for the delay, I was OOF last week. Yes, this is fixed now.

Blackhex mentioned this pull request Feb 6, 2023
Closed

dennisameling commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

This might supersede #44226 in which I added VS2022-specific logic for ARM64, since VS2019 is not supported on that platform. But since MS actively discourages VS2019 installation on ARM64 devices, your approach in this PR is probably better and more future-proof.

sxa commented Feb 6, 2023

Copy link
Copy Markdown
Member

@pbo-linaro Does this look ok to you?

p-b-o commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

@StefanStojanovic will look into this.

StefanStojanovic approved these changes Feb 13, 2023
View reviewed changes

StefanStojanovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if cross-compilation passes in CI.

sxa commented Feb 13, 2023

Copy link
Copy Markdown
Member

LGTM if cross-compilation passes in CI.

I didn't think we had cross-compilation in the main CI just now so I don't think that scenario will be tested, unelss I'm missing something.

StefanStojanovic commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

I didn't think we had cross-compilation in the main CI just now so I don't think that scenario will be tested, unelss I'm missing something.

In the node-compile-windows job, there is a win-vs2019-arm64 configuration, so although we are currently not testing ARM64 in the CI, we should be able to see if the cross-compilation passes at least.

Blackhex commented Feb 27, 2023

Copy link
Copy Markdown
Contributor Author

Please, let me know if there is anything specific I can do for finishing this PR on my end.

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2023

nodejs-github-bot commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50143/

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2023
nodejs-github-bot merged commit 0abe5ec into nodejs:main Mar 2, 2023

nodejs-github-bot commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

Landed in 0abe5ec

dennisameling mentioned this pull request Mar 2, 2023
Closed
targos pushed a commit that referenced this pull request Mar 13, 2023
build: fix Visual Studio installation detection for Arm64
79404e9 
PR-URL: #46420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
build: fix Visual Studio installation detection for Arm64
4b3b009 
PR-URL: #46420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
build: fix Visual Studio installation detection for Arm64
886504f 
PR-URL: #46420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams mentioned this pull request Apr 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
richardlau richardlau approved these changes
StefanStojanovic StefanStojanovic approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL