bootstrap: remove unused global parameter in per-context scripts - #44472
Closed
joyeecheung wants to merge 1 commit into
Closed
bootstrap: remove unused global parameter in per-context scripts#44472joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
joyeecheung
marked this pull request as ready for review
September 1, 2022 07:38
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
approved these changes
Sep 1, 2022
tniessen
approved these changes
Sep 1, 2022
addaleax
approved these changes
Sep 1, 2022
VoltrexKeyva
approved these changes
Sep 1, 2022
JungMinu
approved these changes
Sep 2, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/44472 ✔ Done loading data for nodejs/node/pull/44472 ----------------------------------- PR info ------------------------------------ Title bootstrap: remove unused global parameter in per-context scripts (#44472) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:remove-global -> nodejs:main Labels c++, author ready, needs-ci Commits 1 - bootstrap: remove unused global parameter in per-context scripts Committers 1 - Joyee Cheung PR-URL: https://github.com/nodejs/node/pull/44472 Reviewed-By: Chengzhong Wu Reviewed-By: Tobias Nießen Reviewed-By: Anna Henningsen Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Minwoo Jung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44472 Reviewed-By: Chengzhong Wu Reviewed-By: Tobias Nießen Reviewed-By: Anna Henningsen Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Minwoo Jung -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 01 Sep 2022 07:38:28 GMT ✔ Approvals: 5 ✔ - Chengzhong Wu (@legendecas): https://github.com/nodejs/node/pull/44472#pullrequestreview-1092944173 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/44472#pullrequestreview-1092954123 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/44472#pullrequestreview-1093124829 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/44472#pullrequestreview-1093152278 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/44472#pullrequestreview-1094185837 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-09-01T07:39:16Z: https://ci.nodejs.org/job/node-test-pull-request/46364/ - Querying data for job/node-test-pull-request/46364/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2983750891 |
Sorry, something went wrong.
joyeecheung
added a commit
that referenced
this pull request
Sep 6, 2022
PR-URL: #44472 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
PR-URL: #44472 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
PR-URL: #44472 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Copy link
Copy Markdown
Member
|
This breaks primordials in the v16.x release line |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.