FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bootstrap: generate bootstrapper arguments in BuiltinLoader by joyeecheung · Pull Request #44488 · nodejs/node · GitHub

/ node Public

bootstrap: generate bootstrapper arguments in BuiltinLoader - #44488

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:compile-arg
Sep 13, 2022
ConversationCommits (1)ChecksFiles changed
Merged

bootstrap: generate bootstrapper arguments in BuiltinLoader#44488
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:compile-arg

Conversation

joyeecheung commented Sep 2, 2022

Copy link
Copy Markdown
Member

First commit comes from #44472

joyeecheung marked this pull request as ready for review September 2, 2022 06:29

nodejs-github-bot commented Sep 2, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 2, 2022
joyeecheung mentioned this pull request Sep 2, 2022
Closed
legendecas reviewed Sep 5, 2022
View reviewed changes

legendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The change LGTM, but the linter is complaining...

joyeecheung commented Sep 6, 2022

Copy link
Copy Markdown
Member Author

Rebased and fixed the linter error.

nodejs-github-bot commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46440/

nodejs-github-bot commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46441/

nodejs-github-bot commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46446/

github-actions Bot mentioned this pull request Sep 7, 2022
Open
15 tasks
joyeecheung added the review wanted PRs that need reviews. label Sep 7, 2022
This was referenced Sep 8, 2022
Open
Open
Open
Open
Open

nodejs-github-bot commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46530/

nodejs-github-bot commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46537/

github-actions Bot mentioned this pull request Sep 13, 2022
Open
30 tasks
joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 13, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 13, 2022
nodejs-github-bot merged commit 7850802 into nodejs:main Sep 13, 2022

nodejs-github-bot commented Sep 13, 2022

Copy link
Copy Markdown
Collaborator

Landed in 7850802

github-actions Bot mentioned this pull request Sep 14, 2022
Open
28 tasks
github-actions Bot mentioned this pull request Sep 15, 2022
Open
29 tasks
github-actions Bot mentioned this pull request Sep 16, 2022
Open
23 tasks

RafaelGSS commented Sep 26, 2022

Copy link
Copy Markdown
Member

Hi @joyeecheung. This commit didn't land cleanly on v18.x. Could you please backport?

juanarbol commented Oct 3, 2022

Copy link
Copy Markdown
Member

The builtins thing did not land well in the v16.x release line (#44135); marking this as backport-blocked for the v16.x branch.

RafaelGSS mentioned this pull request Oct 14, 2022
Merged
joyeecheung mentioned this pull request Oct 14, 2022
Merged
codebytere mentioned this pull request Oct 24, 2022
Closed
legendecas mentioned this pull request May 23, 2023
Closed
targos pushed a commit that referenced this pull request Oct 29, 2023
bootstrap: generate bootstrapper arguments in BuiltinLoader
c1bc811 
PR-URL: #44488
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
bootstrap: generate bootstrapper arguments in BuiltinLoader
4e51651 
PR-URL: nodejs/node#44488
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
bootstrap: generate bootstrapper arguments in BuiltinLoader
2b0472f 
PR-URL: nodejs/node#44488
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

legendecas legendecas approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. review wanted PRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL