src: expose LookupAndCompile with parameters - #45142
Closed
codebytere wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
joyeecheung
approved these changes
Oct 24, 2022
Comment thread
src/node_builtins.cc
Outdated
juanarbol
approved these changes
Oct 24, 2022
addaleax
reviewed
Oct 25, 2022
Comment thread
src/node_builtins.h
Outdated
codebytere
force-pushed
the
lookup-and-compile-wrapper
branch
from
d4d1c3a to
5f9feee
Compare
October 26, 2022 20:04
legendecas
approved these changes
Oct 31, 2022
joyeecheung
approved these changes
Nov 1, 2022
joyeecheung
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Still LGTM
Sorry, something went wrong.
codebytere
force-pushed
the
lookup-and-compile-wrapper
branch
from
5f9feee to
3b0d0e1
Compare
November 8, 2022 11:21
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
codebytere
force-pushed
the
lookup-and-compile-wrapper
branch
from
3b0d0e1 to
1fc633a
Compare
November 8, 2022 14:22
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Nov 11, 2022
jasnell
approved these changes
Nov 16, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This needs rebase. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #44018.
This PR exposes a version of LookupAndCompile that takes parameters instead of detecting them based on module IDs.
Electron currently maintains a wrapper to LookupAndCompile, which specifically requires parameters because we pass our own modules to LookupAndCompile in several places:
and therefore need to be able to able to expose the ability to set that.
I do, however, see that Node.js recently added back a version of CompileAndCall which is effectively the same as our own CompileAndCall wrapper, so if it would be better to modify that to allow parameters I would also be happy to take that path.