tools: fix duration_ms to be milliseconds - #44490
Merged
nodejs-github-bot merged 1 commit intoMar 31, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
MoLow
force-pushed
the
fix-duration-ms
branch
from
af07b24 to
bc76d98
Compare
September 2, 2022 07:44
MoLow
force-pushed
the
fix-duration-ms
branch
from
bef9eb6 to
d32e6ad
Compare
September 5, 2022 14:01
Copy link
Copy Markdown
Member
Author
|
@cclauss can you take a look at this and at nodejs/tap2junit#38 ? |
Sorry, something went wrong.
benjamingr
approved these changes
Sep 5, 2022
aduh95
reviewed
Sep 6, 2022
Comment thread
tools/test.py
Outdated
himself65
approved these changes
Sep 6, 2022
aduh95
approved these changes
Sep 6, 2022
juanarbol
approved these changes
Oct 27, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@juanarbol AFAIK this is still blocked due to nodejs/tap2junit#41 |
Sorry, something went wrong.
This was referenced Oct 29, 2022
jasnell
approved these changes
Nov 2, 2022
aduh95
approved these changes
Mar 30, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
34 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
cclauss
approved these changes
Mar 31, 2023
This was referenced Apr 1, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
PR-URL: #44490 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
PR-URL: #44490 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
PR-URL: #44490 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 8, 2023
PR-URL: #44490 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #44490 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured if we land #44450 (merged) it will be best to also fix it here.
this fix depends on nodejs/tap2junit#38 (merged)