doc: remove unnecessary leading commas - #44854
Merged
nodejs-github-bot merged 1 commit intoOct 4, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
There are several locations in the test_runner API docs where the optional first argument to a function was written with a leading comma. Since these are first arguments, the commas can be removed.
Trott
approved these changes
Oct 2, 2022
VoltrexKeyva
approved these changes
Oct 2, 2022
tniessen
approved these changes
Oct 2, 2022
daeyeon
approved these changes
Oct 2, 2022
lpinca
approved these changes
Oct 2, 2022
MoLow
approved these changes
Oct 2, 2022
RaisinTen
approved these changes
Oct 2, 2022
jasnell
approved these changes
Oct 2, 2022
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
There are several locations in the test_runner API docs where the optional first argument to a function was written with a leading comma. Since these are first arguments, the commas can be removed. PR-URL: #44854 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Dec 9, 2022
There are several locations in the test_runner API docs where the optional first argument to a function was written with a leading comma. Since these are first arguments, the commas can be removed. PR-URL: nodejs#44854 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several locations in the test_runner API docs where the optional first argument to a function was written with a leading comma. Since these are first arguments, the commas can be removed.