FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: fix `test_runner` labeling by MoLow · Pull Request #44863 · nodejs/node · GitHub

/ node Public

meta: fix test_runner labeling - #44863

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-test-runner-labels
Oct 2, 2022
ConversationCommits (1)ChecksFiles changed
Merged

meta: fix test_runner labeling#44863
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-test-runner-labels

Conversation

MoLow commented Oct 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

there are 3 issues fixed by this PR (I tested the changes locally)

  1. doc/api/test.md was converted to test Issues and PRs related to the tests. instead of test_runner Issues and PRs related to the test runner subsystem.
  2. lib/test.js was converted to test Issues and PRs related to the tests. instead of test_runner Issues and PRs related to the test runner subsystem.
  3. lib/internal/test_runner/* only adds https://github.com/nodejs/node/labels/dont-land-on-v14.x but does not add test_runner Issues and PRs related to the test runner subsystem. (caused by meta: update test_runner in label-pr-config #44615)

examples:
#44854
#44844

the third issue did not occur yet so there is no example for it

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 2, 2022

MoLow commented Oct 2, 2022

Copy link
Copy Markdown
Member Author

CC @nodejs/test_runner

MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 2, 2022

github-actions Bot commented Oct 2, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
nodejs-github-bot merged commit e5c807e into nodejs:main Oct 2, 2022

nodejs-github-bot commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator

Landed in e5c807e

MoLow deleted the fix-test-runner-labels branch October 2, 2022 11:19
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
meta: label test.js and test.md with test_runner label
2efe4d9 
PR-URL: #44863
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Oct 11, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL