FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

trace_events: fix getCategories by theanarkh · Pull Request #45092 · nodejs/node · GitHub

/ node Public

trace_events: fix getCategories - #45092

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:fix_trace_event_categorys
Oct 24, 2022
Merged

trace_events: fix getCategories#45092
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:fix_trace_event_categorys

Conversation

Copy link
Copy Markdown
Contributor

fix getCategories of trace_events.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 20, 2022
theanarkh force-pushed the fix_trace_event_categorys branch from c9aa695 to a072817 Compare October 20, 2022 14:35
F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2022

This comment was marked as outdated.

Comment thread src/inspector/tracing_agent.cc Outdated
theanarkh force-pushed the fix_trace_event_categorys branch from a072817 to 9d3e05c Compare October 22, 2022 14:35

This comment was marked as outdated.

anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 22, 2022
theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2022

This comment was marked as outdated.

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2022
nodejs-github-bot merged commit aab9f32 into nodejs:main Oct 24, 2022

Copy link
Copy Markdown
Collaborator

Landed in aab9f32

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
PR-URL: #45092
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
theanarkh mentioned this pull request Nov 1, 2022
4 tasks
RafaelGSS mentioned this pull request Nov 1, 2022
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
PR-URL: #45092
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 19, 2022
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45092
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
PR-URL: #45092
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL