FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

trace_events: add new categories by theanarkh · Pull Request #45266 · nodejs/node · GitHub

/ node Public

trace_events: add new categories - #45266

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:add_new_categories
Nov 19, 2022
ConversationCommits (1)ChecksFiles changed
Merged

trace_events: add new categories#45266
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:add_new_categories

Conversation

theanarkh commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

add new categories.

Refs: #45092
Refs: #44458

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 1, 2022
theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2022
github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 2, 2022

github-actions Bot commented Nov 2, 2022

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com///actions/runs/3377836998

theanarkh added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Nov 2, 2022
github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 2, 2022

github-actions Bot commented Nov 2, 2022

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com///actions/runs/3378861038

theanarkh added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Nov 3, 2022
github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 3, 2022

github-actions Bot commented Nov 3, 2022

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/3387378766

theanarkh added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Nov 5, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2022

nodejs-github-bot commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47700/

nodejs-github-bot commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47714/

github-actions Bot mentioned this pull request Nov 6, 2022
Open
18 tasks
theanarkh added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 6, 2022
This was referenced Nov 7, 2022
Open
Open
legendecas approved these changes Nov 8, 2022
View reviewed changes
Comment thread src/inspector/tracing_agent.cc Outdated
theanarkh force-pushed the add_new_categories branch 2 times, most recently from 13d096d to 2509ae1 Compare November 8, 2022 17:34
github-actions Bot mentioned this pull request Nov 12, 2022
Open
19 tasks
github-actions Bot mentioned this pull request Nov 13, 2022
Open
25 tasks

nodejs-github-bot commented Nov 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47902/

github-actions Bot mentioned this pull request Nov 14, 2022
Open
25 tasks

nodejs-github-bot commented Nov 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47923/

github-actions Bot mentioned this pull request Nov 15, 2022
Open
23 tasks

nodejs-github-bot commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47940/

github-actions Bot mentioned this pull request Nov 16, 2022
Open
17 tasks
This was referenced Nov 17, 2022
Open
Open
Open
theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2022

nodejs-github-bot commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48015/

theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2022
nodejs-github-bot merged commit bcc704f into nodejs:main Nov 19, 2022

nodejs-github-bot commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator

Landed in bcc704f

github-actions Bot mentioned this pull request Nov 20, 2022
Open
14 tasks
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
trace_events: add new categories
f441b04 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
trace_events: add new categories
a2256ba 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
trace_events: add new categories
210cbcb 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
trace_events: add new categories
31d2ce8 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
legendecas legendecas approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL