test: make test-eventemitter-asyncresource.js shorter - #45146
Merged
nodejs-github-bot merged 1 commit intoNov 1, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
juanarbol
force-pushed
the
juan/refactor-events-test
branch
from
9dd5cc2 to
b95e139
Compare
October 24, 2022 13:27
lpinca
approved these changes
Oct 24, 2022
Flarna
reviewed
Oct 25, 2022
Comment thread
test/parallel/test-eventemitter-asyncresource.js
Outdated
Flarna
approved these changes
Oct 25, 2022
jasnell
approved these changes
Oct 26, 2022
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
juanarbol
force-pushed
the
juan/refactor-events-test
branch
from
b95e139 to
c27bb19
Compare
October 28, 2022 17:42
Flarna
approved these changes
Oct 28, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Oct 29, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45146 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45146 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45146 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan José Arboleda soyjuanarbol@gmail.com