FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: refactor `test-whatwg-webstreams-encoding` to be shorter by hidaviddong · Pull Request #54569 · nodejs/node · GitHub

/ node Public

test: refactor test-whatwg-webstreams-encoding to be shorter - #54569

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
hidaviddong:main
Sep 19, 2024
Merged

test: refactor test-whatwg-webstreams-encoding to be shorter#54569
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
hidaviddong:main

Conversation

Copy link
Copy Markdown
Contributor

Use a forEach loop for assert.throws statements, improving code readability.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 26, 2024

lpinca commented Aug 29, 2024

Copy link
Copy Markdown
Member

@hidaviddong please remove the merge commit.

Copy link
Copy Markdown
Contributor Author

@hidaviddong please remove the merge commit.

done

lpinca added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 29, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024

This comment was marked as outdated.

Copy link
Copy Markdown
Member

Use a forEach loop for assert.throws statements, improving code readability.

This will make diagnosing any failures harder as the stack traces will now point to the loop without an indication of which iteration of the loop failed.

Copy link
Copy Markdown
Contributor Author

Use a forEach loop for assert.throws statements, improving code readability.

This will make diagnosing any failures harder as the stack traces will now point to the loop without an indication of which iteration of the loop failed.

Do I need to add a stack trace? like done in #45146

Copy link
Copy Markdown
Member

Use a forEach loop for assert.throws statements, improving code readability.

This will make diagnosing any failures harder as the stack traces will now point to the loop without an indication of which iteration of the loop failed.

Do I need to add a stack trace? like done in #45146

I think that would work.

hidaviddong changed the title test: refactor test-whatwg-webstreams-encoding to be shorter test: refactor test-whatwg-webstreams-encoding to be shorter Aug 29, 2024

codecov Bot commented Aug 29, 2024
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.31%. Comparing base (4ce9864) to head (9738074).
Report is 737 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54569      +/-   ##
==========================================
- Coverage   87.33%   87.31%   -0.03%     
==========================================
  Files         649      649              
  Lines      182623   182755     +132     
  Branches    35041    35051      +10     
==========================================
+ Hits       159498   159575      +77     
- Misses      16400    16452      +52     
- Partials     6725     6728       +3     

see 54 files with indirect coverage changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024

This comment was marked as outdated.

nodejs-github-bot commented Aug 29, 2024
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Contributor Author

I see a CI failure, but I'm not sure what caused it. Do I need to change anything?

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 8, 2024
richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024
nodejs-github-bot merged commit 291d90a into nodejs:main Sep 19, 2024

Copy link
Copy Markdown
Collaborator

Landed in 291d90a

targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #54569
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 mentioned this pull request Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. web streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL