FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: add extra semi check by gengjiawen · Pull Request #46194 · nodejs/node · GitHub

/ node Public

build: add extra semi check - #46194

Closed
gengjiawen wants to merge 2 commits into
nodejs:mainfrom
gengjiawen:feat/semi
ConversationCommits (2)ChecksFiles changed
Closed

build: add extra semi check#46194
gengjiawen wants to merge 2 commits into
nodejs:mainfrom
gengjiawen:feat/semi

Conversation

gengjiawen commented Jan 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Make more friendly with electronjs.

context: #46171 (comment)

cc @richardlau

Should fail until #46171 is merged.

nodejs-github-bot commented Jan 13, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 13, 2023

gengjiawen commented Jan 13, 2023

Copy link
Copy Markdown
Member Author

https://github.com/nodejs/node/actions/runs/3908559309/jobs/6678809081 show flags works.

rebased to make CI green (#46171 merged now)

gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023

nodejs-github-bot commented Jan 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48962/

gengjiawen commented Jan 13, 2023

Copy link
Copy Markdown
Member Author

simdutf upstream: simdutf/simdutf#207

gengjiawen mentioned this pull request Jan 13, 2023
Merged
This was referenced Jan 14, 2023
Open
Open
Open
gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2023

nodejs-github-bot commented Jan 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48996/

gengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jan 16, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 16, 2023

This comment was marked as outdated.

Sign in to view
gengjiawen requested a review from richardlau January 16, 2023 14:25
github-actions Bot mentioned this pull request Jan 17, 2023
Open
17 tasks
gengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 17, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 17, 2023

nodejs-github-bot commented Jan 17, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8986bf8...17aa195

nodejs-github-bot pushed a commit that referenced this pull request Jan 17, 2023
build: add extra semi check
3e7043a 
PR-URL: #46194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jan 17, 2023
deps: cherrypick simdutf patch
17aa195 
PR-URL: #46194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
gengjiawen deleted the feat/semi branch January 17, 2023 01:27
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
build: add extra semi check
6ae29dd 
PR-URL: nodejs#46194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
deps: cherrypick simdutf patch
43c4146 
PR-URL: nodejs#46194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This was referenced Jan 18, 2023
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
build: add extra semi check
370f621 
PR-URL: #46194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
deps: cherrypick simdutf patch
3f9fb37 
PR-URL: #46194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
build: add extra semi check
6c8a26c 
PR-URL: #46194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
deps: cherrypick simdutf patch
ca6adb1 
PR-URL: #46194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
build: add extra semi check
3bf2371 
PR-URL: #46194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
deps: cherrypick simdutf patch
340d76a 
PR-URL: #46194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
richardlau richardlau approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL