deps: bump googletest to 2023.01.13 - #46198
Merged
nodejs-github-bot merged 1 commit intoJan 15, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @gengjiawen. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
approved these changes
Jan 13, 2023
Copy link
Copy Markdown
Member
If this is not a release, could you include the commit hash you bumped to in the commit message? |
Sorry, something went wrong.
tniessen
approved these changes
Jan 13, 2023
cjihrig
approved these changes
Jan 13, 2023
Copy link
Copy Markdown
Member
Author
For the hash Sure. But googletest will not draft any new release. Hash looks the only way in the future.
|
Sorry, something went wrong.
commit hash: 356fc301251378e0f6fa6aa794d73714202887ac
gengjiawen
force-pushed
the
feat/bump_gtest
branch
from
ce8dd46 to
c14d83d
Compare
January 13, 2023 15:33
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Jan 14, 2023
16 tasks
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/46198 ✔ Done loading data for nodejs/node/pull/46198 ----------------------------------- PR info ------------------------------------ Title deps: bump googletest to 2023.01.13 (#46198) Author Jiawen Geng (@gengjiawen) Branch gengjiawen:feat/bump_gtest -> nodejs:main Labels fast-track, needs-ci, dependencies Commits 1 - deps: bump googletest to 2023.01.13 Committers 1 - Jiawen Geng PR-URL: https://github.com/nodejs/node/pull/46198 Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46198 Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 13 Jan 2023 10:14:51 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/46198#pullrequestreview-1247529039 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/46198#pullrequestreview-1247678664 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46198#pullrequestreview-1247778622 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46198#pullrequestreview-1248977483 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-01-14T00:22:53Z: https://ci.nodejs.org/job/node-test-pull-request/48978/ - Querying data for job/node-test-pull-request/48978/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3923324332 |
Sorry, something went wrong.
This was referenced Jan 16, 2023
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
commit hash: 356fc301251378e0f6fa6aa794d73714202887ac PR-URL: nodejs#46198 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jan 18, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
commit hash: 356fc301251378e0f6fa6aa794d73714202887ac PR-URL: #46198 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
commit hash: 356fc301251378e0f6fa6aa794d73714202887ac PR-URL: #46198 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
commit hash: 356fc301251378e0f6fa6aa794d73714202887ac PR-URL: #46198 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subtask of #46194.
Also fix some issue on cpp20.