FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

esm: skip file: URL conversion to path when possible by aduh95 · Pull Request #46305 · nodejs/node · GitHub

/ node Public

esm: skip file: URL conversion to path when possible - #46305

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
aduh95:esm-path-to-url-optimizations
Apr 1, 2023
ConversationCommits (6)ChecksFiles changed
Merged

esm: skip file: URL conversion to path when possible#46305
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
aduh95:esm-path-to-url-optimizations

Conversation

aduh95 commented Jan 22, 2023

Copy link
Copy Markdown
Contributor

require('node:path').extname has to do several checks to comply with relative paths, however URL instances are always absolute so skipping the translation to a path and implement a simplified version of extname makes sense IMHO.

We could potentially do the same for basename, but it's only used in the error path where performance don't matter as much, so this PR is only doing extname.

nodejs-github-bot commented Jan 22, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jan 22, 2023
GeoffreyBooth reviewed Jan 22, 2023
View reviewed changes
Comment thread lib/internal/modules/esm/get_format.js Outdated
aduh95 force-pushed the esm-path-to-url-optimizations branch from c643491 to 9fdbd99 Compare March 18, 2023 11:46
aduh95 requested a review from GeoffreyBooth March 18, 2023 11:46
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 18, 2023
aduh95 commented Mar 18, 2023
View reviewed changes
Comment thread lib/internal/modules/esm/get_format.js Outdated
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2023

nodejs-github-bot commented Mar 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50448/

github-actions Bot mentioned this pull request Mar 19, 2023
Open
19 tasks
JakobJingleheimer approved these changes Mar 19, 2023
View reviewed changes
Comment thread lib/internal/modules/esm/get_format.js Outdated

nodejs-github-bot commented Mar 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50461/

JakobJingleheimer reviewed Mar 19, 2023
View reviewed changes
Comment thread lib/internal/modules/esm/get_format.js Outdated
JakobJingleheimer reviewed Mar 19, 2023
View reviewed changes
Comment thread lib/internal/modules/esm/get_format.js Outdated
aduh95 commented Mar 19, 2023
View reviewed changes
Comment thread lib/internal/modules/esm/get_format.js Outdated
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 19, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 19, 2023

nodejs-github-bot commented Mar 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50463/

nodejs-github-bot commented Mar 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50670/

This was referenced Mar 30, 2023
Open
Open

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50739/

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50756/

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50760/

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50767/

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50772/

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50773/

github-actions Bot mentioned this pull request Apr 1, 2023
Open
38 tasks
aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 1, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 1, 2023
nodejs-github-bot merged commit aa5eb58 into nodejs:main Apr 1, 2023

nodejs-github-bot commented Apr 1, 2023

Copy link
Copy Markdown
Collaborator

Landed in aa5eb58

aduh95 deleted the esm-path-to-url-optimizations branch April 1, 2023 08:14
github-actions Bot mentioned this pull request Apr 2, 2023
Open
30 tasks
RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
esm: skip file: URL conversion to path when possible
8425ea3 
PR-URL: #46305
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
esm: skip file: URL conversion to path when possible
84198fa 
PR-URL: #46305
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
esm: skip file: URL conversion to path when possible
f950ac9 
PR-URL: #46305
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
esm: skip file: URL conversion to path when possible
a4b1a77 
PR-URL: #46305
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2023
esm: skip file: URL conversion to path when possible
dfa4444 
PR-URL: #46305
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
esm: skip file: URL conversion to path when possible
7cfb6d8 
PR-URL: nodejs/node#46305
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
esm: skip file: URL conversion to path when possible
014e016 
PR-URL: nodejs/node#46305
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JakobJingleheimer JakobJingleheimer approved these changes
jasnell jasnell approved these changes
GeoffreyBooth GeoffreyBooth approved these changes
guybedford guybedford approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL