deps: update nghttp2 to 1.52.0 - #46636
Merged
nodejs-github-bot merged 1 commit intoFeb 22, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
cjihrig
approved these changes
Feb 13, 2023
VoltrexKeyva
approved these changes
Feb 13, 2023
RafaelGSS
approved these changes
Feb 15, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I left a comment here about config.h #45572 (comment), it cannot be deleted and it is referenced here Line 15 in a2bbe5f |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
34 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
the update now works automatically #46773 🎉 |
Sorry, something went wrong.
31 tasks
targos
added a commit
that referenced
this pull request
Mar 13, 2023
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.52.0 PR-URL: #46636 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.52.0 PR-URL: #46636 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.52.0
Note that #45572 is still relevant.
I don't know if config.h is a generated file. I just reverted its removal.