FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update nghttp2 to 1.53.0 by nodejs-github-bot · Pull Request #47997 · nodejs/node · GitHub

/ node Public

deps: update nghttp2 to 1.53.0 - #47997

Merged
nodejs-github-bot merged 2 commits into
mainfrom
actions/tools-update-nghttp2
May 18, 2023
ConversationCommits (2)ChecksFiles changed
Merged

deps: update nghttp2 to 1.53.0#47997
nodejs-github-bot merged 2 commits into
mainfrom
actions/tools-update-nghttp2

Conversation

nodejs-github-bot commented May 14, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of nghttp2 to 1.53.0.

nodejs-github-bot added the dependencies Pull requests that update a dependency file. label May 14, 2023

nodejs-github-bot commented May 14, 2023

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/http2
  • @nodejs/net

nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels May 14, 2023
RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2023

RafaelGSS commented May 14, 2023

Copy link
Copy Markdown
Member

why is it conflicting? @marco-ippolito

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2023

marco-ippolito commented May 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

why is it conflicting? @marco-ippolito

because of this #46636 which changed #define NGHTTP2_VERSION_NUM 0x013400 , anyways it does not build

nodejs-github-bot commented May 14, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51797/

marco-ippolito force-pushed the actions/tools-update-nghttp2 branch from a146d6f to 2be2202 Compare May 14, 2023 18:09
github-actions Bot mentioned this pull request May 15, 2023
Open
17 tasks

nodejs-github-bot commented May 15, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51814/

marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels May 15, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2023

nodejs-github-bot commented May 15, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51815/

github-actions Bot mentioned this pull request May 16, 2023
Open
19 tasks

nodejs-github-bot commented May 16, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51827/

This was referenced May 17, 2023
Open
Open

nodejs-github-bot commented May 18, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51863/

nodejs-github-bot commented May 18, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51864/

marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 18, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2023
nodejs-github-bot merged commit 3538e1b into main May 18, 2023
nodejs-github-bot deleted the actions/tools-update-nghttp2 branch May 18, 2023 13:59

nodejs-github-bot commented May 18, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in 3538e1b

This was referenced May 19, 2023
Open
Open
Open
Open
This was referenced May 23, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request May 30, 2023
deps: update nghttp2 to 1.53.0
d3e3a91 
PR-URL: #47997
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
targos mentioned this pull request Jun 4, 2023
Merged

danielleadams commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

This should be backported to v18.x - it breaks the build on the staging branch.

richardlau pushed a commit to richardlau/node-1 that referenced this pull request Oct 11, 2023
deps: update nghttp2 to 1.53.0
985a204 
PR-URL: nodejs#47997
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
richardlau mentioned this pull request Oct 11, 2023
Closed

richardlau commented Oct 11, 2023

Copy link
Copy Markdown
Member

Opened a backport PR for this and other nghttp2 versions to Node.js 18: #50151

richardlau pushed a commit that referenced this pull request Oct 12, 2023
deps: update nghttp2 to 1.53.0
300a902 
PR-URL: #47997
Backport-PR-URL: #50151
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
hermanbanken mentioned this pull request Mar 27, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
RafaelGSS RafaelGSS approved these changes
marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL