test: reduce flakiness of parallel/test-http-remove-header-stays-removed.js - #46855
Merged
nodejs-github-bot merged 2 commits intoMar 18, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
debadree25
force-pushed
the
ft/improve-test-http-remove-header
branch
from
37b2da5 to
2c2b37c
Compare
February 27, 2023 07:34
debadree25
force-pushed
the
ft/improve-test-http-remove-header
branch
from
2c2b37c to
e0e39c6
Compare
February 27, 2023 07:36
Copy link
Copy Markdown
Member
|
Does this allow a bug during flakiness? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Didn't get you? 😅😅 |
Sorry, something went wrong.
This comment was marked as outdated.
This was referenced Mar 1, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
18 tasks
mcollina
reviewed
Mar 13, 2023
Comment thread
test/parallel/test-http-remove-header-stays-removed.js
Outdated
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
approved these changes
Mar 16, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Refs: nodejs/reliability#508 Refs: #46333 PR-URL: #46855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Refs: nodejs/reliability#508 Refs: #46333 PR-URL: #46855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Refs: nodejs/reliability#508 Refs: #46333 PR-URL: #46855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test test-http-remove-header-stays-removed.js seems to be slightly flaky as seen in nodejs/reliability#508 and also reproducible locally by running python3 tools/test.py test/parallel/test-http-remove-header-stays-removed.js --repeat 1000
Since the test checks that the socket is closed right after receiving the last chunk of data hence moved the checking for the same after the data has been received and slightly increased the timeout, the flakiness no longer reproduces
Refs: nodejs/reliability#508
Refs: #46333