inspector: log response and requests in the inspector for debugging - #46941
Merged
nodejs-github-bot merged 2 commits intoMar 22, 2023
Merged
inspector: log response and requests in the inspector for debugging#46941nodejs-github-bot merged 2 commits into
nodejs-github-bot merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE is set to inspector_server to facilitate debugging.
Copy link
Copy Markdown
Member
Author
|
By the way I am not sure since when we stopped using INSPECTOR_SERVER, but before this patch INSPECTOR_SERVER is otherwise unused. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
reviewed
Mar 3, 2023
…gging Co-authored-by: Anna Henningsen <github@addaleax.net>
This was referenced Mar 8, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/46941 ✔ Done loading data for nodejs/node/pull/46941 ----------------------------------- PR info ------------------------------------ Title inspector: log response and requests in the inspector for debugging (#46941) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:inspector-debug -> nodejs:main Labels c++, inspector, needs-ci, commit-queue-squash Commits 2 - inspector: log response and requests in the inspector for debugging - fixup! inspector: log response and requests in the inspector for debu… Committers 2 - Joyee Cheung - GitHub PR-URL: https://github.com/nodejs/node/pull/46941 ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46941 -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup! inspector: log response and requests in the inspector for debu… ℹ This PR was created on Fri, 03 Mar 2023 18:15:18 GMT ✘ Approvals: 0 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-03-13T16:29:57Z: https://ci.nodejs.org/job/node-test-pull-request/50357/ - Querying data for job/node-test-pull-request/50357/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4451496611 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/inspector @nodejs/cpp-reviewers can I have some review please? |
Sorry, something went wrong.
RafaelGSS
approved these changes
Mar 18, 2023
RafaelGSS
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Mar 19, 2023
RaisinTen
approved these changes
Mar 20, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
33 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE is set to inspector_server to facilitate debugging. PR-URL: #46941 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE is set to inspector_server to facilitate debugging. PR-URL: #46941 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE is set to inspector_server to facilitate debugging. PR-URL: #46941 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE is set to inspector_server to facilitate debugging.