src: remove SSL_CTX_get_tlsext_ticket_keys guards - #47068
Merged
nodejs-github-bot merged 1 commit intoMar 15, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
OPENSSL_NO_TLSEXT was removed from OpenSSL a long time ago and both OpenSSL and BoringSSL always unconditionally define SSL_CTX_get_tlsext_ticket_keys now.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
panva
approved these changes
Mar 13, 2023
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Mar 13, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Mar 14, 2023
This was referenced Mar 16, 2023
targos
pushed a commit
that referenced
this pull request
Mar 18, 2023
OPENSSL_NO_TLSEXT was removed from OpenSSL a long time ago and both OpenSSL and BoringSSL always unconditionally define SSL_CTX_get_tlsext_ticket_keys now. PR-URL: #47068 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
19 tasks
This was referenced Apr 3, 2023
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
OPENSSL_NO_TLSEXT was removed from OpenSSL a long time ago and both OpenSSL and BoringSSL always unconditionally define SSL_CTX_get_tlsext_ticket_keys now. PR-URL: #47068 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OPENSSL_NO_TLSEXT was removed from OpenSSL a long time ago and both OpenSSL and BoringSSL always unconditionally define SSL_CTX_get_tlsext_ticket_keys now.