src: fix duplication of externalized builtin code - #47079
Merged
nodejs-github-bot merged 1 commit intoMar 17, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The `else` here was missing, causing us to append the file to its existing `source` already in the map. Refs: nodejs#45942
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Mar 14, 2023
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @addaleax. Please 👍 to approve. |
Sorry, something went wrong.
This comment was marked as outdated.
cjihrig
approved these changes
Mar 14, 2023
lpinca
approved these changes
Mar 15, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Can somebody retry the failed CI build for me because I cannot? It looks like the build timed out after 60 minutes on node-test-linux-linked-openssl111fips, which seems obviously unrelated: https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubi81_sharedlibs_openssl111fips_x64/36558/ Thanks :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
23 tasks
This was referenced Mar 19, 2023
Merged
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
The `else` here was missing, causing us to append the file to its existing `source` already in the map. Refs: nodejs/node#45942 PR-URL: nodejs/node#47079 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
The `else` here was missing, causing us to append the file to its existing `source` already in the map. Refs: nodejs/node#45942 PR-URL: nodejs/node#47079 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The else here was missing, causing us to append the file to its existing source already in the map.
Refs: #45942