doc: rename the startup performance initiative to startup snapshot - #47111
doc: rename the startup performance initiative to startup snapshot#47111mhdawson merged 1 commit into
Conversation
Sorry, something went wrong.
The initiative has been more focused on startup snapshot integration which is more of a feature on its own, so rename it to "startup snapshot". Background: we are also considering adding a more generic performance initiative in nodejs/TSC#1343.
|
Review requested:
|
Sorry, something went wrong.
mhdawson
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
This was landed without commit metadata, but that happened 13 hours ago and 2 other commits were landed on top of it. I don't know if we can still force-push... |
Sorry, something went wrong.
|
@targos can we enable GitHub's "Require status checks to pass before merging" and post a required status report that never passes to block the "merge" button? This still allows node-core-util to land commits since it pushes to the main branch directly. |
Sorry, something went wrong.
|
Not really. The commit queue uses the "squash and merge" button (with a GitHub API call) |
Sorry, something went wrong.
|
Also, if you require status checks to pass before merging, it becomes impossible to push a commit directly, as it wouldn't have the required check. |
Sorry, something went wrong.
|
good to know that. thanks for the explanation! |
Sorry, something went wrong.
…47111) The initiative has been more focused on startup snapshot integration which is more of a feature on its own, so rename it to "startup snapshot". Background: we are also considering adding a more generic performance initiative in nodejs/TSC#1343.
…47111) The initiative has been more focused on startup snapshot integration which is more of a feature on its own, so rename it to "startup snapshot". Background: we are also considering adding a more generic performance initiative in nodejs/TSC#1343.
…47111) The initiative has been more focused on startup snapshot integration which is more of a feature on its own, so rename it to "startup snapshot". Background: we are also considering adding a more generic performance initiative in nodejs/TSC#1343.
The initiative has been more focused on startup snapshot integration which is more of a feature on its own, so rename it to "startup snapshot".
Background: we are also considering adding a more generic performance initiative in nodejs/TSC#1343.