FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-http-max-sockets as flaky on win32 by tniessen · Pull Request #47134 · nodejs/node · GitHub

/ node Public

test: mark test-http-max-sockets as flaky on win32 - #47134

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:test-http-max-sockets-flaky-on-win32
Mar 17, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: mark test-http-max-sockets as flaky on win32#47134
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:test-http-max-sockets-flaky-on-win32

Conversation

tniessen commented Mar 17, 2023

Copy link
Copy Markdown
Member

Current Windows CI build trend:

I am not sure if marking it as flaky is going to be enough. Maybe we have to skip it entirely, but that's something that we should try to avoid.

Refs: #47116

tniessen added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 17, 2023

github-actions Bot commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 17, 2023
tniessen mentioned this pull request Mar 17, 2023
Closed
anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 17, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2023

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Mar 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50420/

tniessen commented Mar 17, 2023

Copy link
Copy Markdown
Member Author

Test was correctly detected as being flaky in the previous Jenkins run, but some other tests on other platforms flaked, too...

tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 17, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 17, 2023
nodejs-github-bot merged commit 9e9f68a into nodejs:main Mar 17, 2023

nodejs-github-bot commented Mar 17, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9e9f68a

tniessen mentioned this pull request Mar 17, 2023
Merged
github-actions Bot mentioned this pull request Mar 18, 2023
Open
23 tasks
targos pushed a commit that referenced this pull request Mar 18, 2023
test: mark test-http-max-sockets as flaky on win32
7bcfd18 
Refs: #47116
PR-URL: #47134
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
This was referenced Mar 19, 2023
Open
Open
Open
debadree25 mentioned this pull request Mar 21, 2023
Closed
This was referenced Apr 3, 2023
Merged
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
test: mark test-http-max-sockets as flaky on win32
713b412 
Refs: #47116
PR-URL: #47134
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
BethGriggs BethGriggs approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL