node-api: extend type-tagging to externals - #47141
Merged
nodejs-github-bot merged 6 commits intoMar 22, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Since externals behave as JavaScript objects on the JavaScript side, allow them to be type-tagged. Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mhdawson
approved these changes
Mar 17, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@mhdawson oof! You can't just pick any number for the type tag parameter. It's actually an index into a static array of 5 type tags. I inadvertently caused the test to index beyond the end of the array, and somehow armv7l happened to catch me. Fixed now, and I added a macro to validate the type index passed in from JS. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Mar 19, 2023
legendecas
approved these changes
Mar 20, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
gabrielschulhof
deleted the
node-addon-api-1293-verify-type-tagging-of-externals
branch
March 22, 2023 04:49
33 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Since externals behave as JavaScript objects on the JavaScript side, allow them to be type-tagged. Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com> PR-URL: #47141 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Since externals behave as JavaScript objects on the JavaScript side, allow them to be type-tagged. Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com> PR-URL: #47141 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Since externals behave as JavaScript objects on the JavaScript side, allow them to be type-tagged. Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com> PR-URL: #47141 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since externals behave as JavaScript objects on the JavaScript side, allow them to be type-tagged.