FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

buffer: use private properties for brand checks in File by KhafraDev · Pull Request #47154 · nodejs/node · GitHub

/ node Public

buffer: use private properties for brand checks in File - #47154

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
KhafraDev:file-brand-checks
Mar 20, 2023
ConversationCommits (1)ChecksFiles changed
Merged

buffer: use private properties for brand checks in File#47154
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
KhafraDev:file-brand-checks

Conversation

KhafraDev commented Mar 18, 2023

Copy link
Copy Markdown
Member

The current checks wouldn't work for certain values, and other places in the code have moved to this behavior as well.

import { File } from 'node:buffer'

const pd = Object.getOwnPropertyDescriptor(File.prototype, 'name')

pd.get.call(true) // Uncaught TypeError: Cannot use 'in' operator to search for '#name' in true

pd.get.call(null) // Uncaught TypeError [ERR_INVALID_THIS]: Value of "this" must be of type File

Refs: #46904

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 18, 2023
anonrig added semver-major PRs that contain breaking changes and should be released in the next major version. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2023

nodejs-github-bot commented Mar 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50451/

anonrig commented Mar 19, 2023

Copy link
Copy Markdown
Member

Since, this change is done on an experimental API, I'll remove my tag of semver-major. If this is wrongly removed, please add it.

anonrig removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 19, 2023

nodejs-github-bot commented Mar 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50455/

github-actions Bot mentioned this pull request Mar 20, 2023
Open
17 tasks
anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 20, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 20, 2023
nodejs-github-bot merged commit 252a069 into nodejs:main Mar 20, 2023

nodejs-github-bot commented Mar 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in 252a069

KhafraDev deleted the file-brand-checks branch March 20, 2023 22:22
github-actions Bot mentioned this pull request Mar 21, 2023
Open
19 tasks
debadree25 mentioned this pull request Mar 21, 2023
Closed
github-actions Bot mentioned this pull request Mar 22, 2023
Open
19 tasks
anonrig mentioned this pull request Mar 26, 2023
Closed
RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
buffer: use private properties for brand checks in File
d639f2e 
PR-URL: #47154
Refs: #46904
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
buffer: use private properties for brand checks in File
e3d98c3 
PR-URL: #47154
Refs: #46904
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
buffer: use private properties for brand checks in File
4c69be4 
PR-URL: #47154
Refs: #46904
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
coderabbitai Bot mentioned this pull request Aug 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL