tools: allow test tap output to include Unicode characters - #47175
Merged
nodejs-github-bot merged 1 commit intoMar 21, 2023
Merged
tools: allow test tap output to include Unicode characters#47175nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
richardlau
approved these changes
Mar 20, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
approved these changes
Mar 20, 2023
Copy link
Copy Markdown
Member
|
Well this doesn't look quite right 😆: 17:24:54 b'ok 2119 parallel/test-readline-async-iterators'
17:24:54 ---
17:24:54 duration_ms: 10.526
17:24:54 ...
17:24:55 b'ok 2120 parallel/test-repl-history-perm'
17:24:55 ---
17:24:55 duration_ms: 0.118
17:24:55 ...Note the "b" prefix and single quotes. This results in: |
Sorry, something went wrong.
cclauss
approved these changes
Mar 20, 2023
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
If you want the second representation (b'L\xc3\xbcsai') instead of the first (Lüsai) then I approve.
>>> import logging
>>> logger = logging.getLogger()
>>> logger.warning("Lüsai")
Lüsai
>>> logger.warning("Lüsai".encode("utf-8"))
b'L\xc3\xbcsai'
Sorry, something went wrong.
richardlau
requested changes
Mar 20, 2023
richardlau
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry, something went wrong.
cclauss
self-requested a review
March 20, 2023 18:13
19 tasks
MoLow
force-pushed
the
allow-tap-to-include-utf
branch
from
2b47470 to
f83d168
Compare
March 21, 2023 07:17
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
approved these changes
Mar 21, 2023
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @MoLow. Please 👍 to approve. |
Sorry, something went wrong.
cclauss
approved these changes
Mar 21, 2023
This was referenced Mar 22, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
PR-URL: #47175 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
PR-URL: #47175 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47175 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47173
the issue can be easily reproduced locally by adding sys.stdout.reconfigure(encoding='ascii') to the beginning of tools/test.py