url: add pending-deprecation to url.parse() - #47203
Merged
nodejs-github-bot merged 2 commits intoMar 23, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
anonrig
force-pushed
the
pending-deprecation-url-parse
branch
from
30891b9 to
6ef70eb
Compare
March 21, 2023 19:40
Copy link
Copy Markdown
Member
Author
|
@nodejs/tsc please review |
Sorry, something went wrong.
anonrig
force-pushed
the
pending-deprecation-url-parse
branch
from
6ef70eb to
e921846
Compare
March 21, 2023 19:47
joyeecheung
reviewed
Mar 21, 2023
Comment thread
lib/url.js
Outdated
anonrig
force-pushed
the
pending-deprecation-url-parse
branch
from
e921846 to
476c1ee
Compare
March 21, 2023 22:10
mscdex
reviewed
Mar 21, 2023
Comment thread
lib/url.js
Outdated
jasnell
approved these changes
Mar 21, 2023
RaisinTen
approved these changes
Mar 22, 2023
legendecas
approved these changes
Mar 22, 2023
mcollina
approved these changes
Mar 22, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
BethGriggs
approved these changes
Mar 22, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
33 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
joyeecheung
approved these changes
Mar 23, 2023
Copy link
Copy Markdown
Member
|
Why is this semver-major? IIRC we don't treat "pending deprecation" as breaking (or notable). The deprecation is still documentation-only. The original introduction of the documentation-only status was a notable change, yet not semver-major. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thank you @tniessen. I wasn't aware of that. I removed the label. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
That way we can backport it :) |
Sorry, something went wrong.
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
PR-URL: #47203 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
PR-URL: #47203 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47203 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose adding support for --pending-deprecation for the url.parse() method. The new improvements in WHATWG URL and Ada hints us towards a runtime deprecation in the upcoming years.