FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: automate brotli update by marco-ippolito · Pull Request #47205 · nodejs/node · GitHub

/ node Public

tools: automate brotli update - #47205

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/automate-brotli-update
Mar 31, 2023
ConversationCommits (1)ChecksFiles changed
Merged

tools: automate brotli update#47205
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/automate-brotli-update

Conversation

marco-ippolito commented Mar 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Refs: nodejs/security-wg#828
This is the first attempt to automate brotli update.
These two files get deleted by the update, maybe we should save them?
https://github.com/nodejs/node/blob/main/deps/brotli/c/common/dictionary.bin.br
https://github.com/nodejs/node/blob/main/deps/brotli/c/common/dictionary.bin
@nodejs/security-wg

nodejs-github-bot commented Mar 21, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

marco-ippolito requested a review from addaleax March 21, 2023 22:05
nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Mar 21, 2023
anonrig reviewed Mar 21, 2023
View reviewed changes

anonrig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The commit & pull request title is wrong. brotly should be brotli.

marco-ippolito changed the title tools: automate brotly update tools: automate brotli update Mar 21, 2023
marco-ippolito force-pushed the feat/automate-brotli-update branch from 1bcb492 to efc3c43 Compare March 21, 2023 22:23
mcollina approved these changes Mar 22, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mhdawson commented Mar 22, 2023

Copy link
Copy Markdown
Member

These two files get deleted by the update, maybe we should save them?

Do you mean that when updated Node.js will no longer have those files? They still existing in the main branch of brotli so them being removed does not make sense to me.

mhdawson commented Mar 22, 2023

Copy link
Copy Markdown
Member

This is where I see them still existing in the upstream - https://github.com/google/brotli/tree/master/c/common

marco-ippolito commented Mar 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

@mhdawson they are not present in the c/common folder of the release zip/tar.gz, which is odd

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
nodejs-github-bot merged commit da8c099 into nodejs:main Mar 31, 2023

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

Landed in da8c099

RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
tools: automate brotli update
c427e5b 
PR-URL: #47205
Refs: nodejs/security-wg#828
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
tools: automate brotli update
0f4c6c9 
PR-URL: #47205
Refs: nodejs/security-wg#828
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
tools: automate brotli update
34b6d65 
PR-URL: #47205
Refs: nodejs/security-wg#828
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
tools: automate brotli update
30c667e 
PR-URL: #47205
Refs: nodejs/security-wg#828
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
tools: automate brotli update
5d46c59 
PR-URL: #47205
Refs: nodejs/security-wg#828
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig left review comments
mcollina mcollina approved these changes
UlisesGascon UlisesGascon approved these changes
addaleax Awaiting requested review from addaleax
+1 more reviewer
edsadr edsadr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL