FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: V8: cherry-pick 3e4952cb2a59 by richardlau · Pull Request #47236 · nodejs/node · GitHub

/ node Public

deps: V8: cherry-pick 3e4952cb2a59 - #47236

Closed
richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:gcc-10
ConversationCommits (1)ChecksFiles changed
Closed

deps: V8: cherry-pick 3e4952cb2a59#47236
richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:gcc-10

Conversation

richardlau commented Mar 23, 2023

Copy link
Copy Markdown
Member

Original commit message:

[test] fix uninitialized error

In op1a.Equals(&op3) call, that->parameter() is undefined.
which triggers uninitialized error from gcc.

Change-Id: I87f1fcba3e57adbb5a1e745a3d787c62a87fd1d3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4307714
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86267}

Refs: v8/v8@3e4952c

Fixes the V8 CI with gcc-10 (thanks @john-yan).
https://ci.nodejs.org/job/node-test-commit-v8-linux/5241/nodes=rhel8-s390x,v8test=v8test/console

15:39:58 In file included from ../../test/cctest/compiler/test-operator.cc:8:
15:39:58 ../../src/compiler/operator.h: In function ‘void v8::internal::compiler::TestTestOperator1double_Equals()’:
15:39:58 ../../src/compiler/operator.h:185:23: error: array subscript 6 is outside array bounds of ‘v8::internal::compiler::Operator [1]’ [-Werror=array-bounds]
15:39:58   185 |     return this->pred_(this->parameter(), that->parameter());
15:39:58       |            ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
15:39:58 ../../test/cctest/compiler/test-operator.cc:213:12: note: while referencing ‘op3’
15:39:58   213 |   Operator op3(25, NONE, "Weepy", 0, 0, 0, 0, 0, 0);
15:39:58       |            ^~~

cc @nodejs/v8-update

deps: V8: cherry-pick 3e4952cb2a59
ae66cd6 
Original commit message:

    [test] fix uninitialized error

    In op1a.Equals(&op3) call, that->parameter() is undefined.
    which triggers uninitialized error from gcc.

    Change-Id: I87f1fcba3e57adbb5a1e745a3d787c62a87fd1d3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4307714
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#86267}

Refs: v8/v8@3e4952c

nodejs-github-bot commented Mar 23, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Mar 23, 2023
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 23, 2023

nodejs-github-bot commented Mar 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50572/

richardlau mentioned this pull request Mar 23, 2023
Merged

nodejs-github-bot commented Mar 23, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5243/

nodejs-github-bot commented Mar 23, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5243/

nodejs-github-bot commented Mar 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50576/

richardlau added a commit that referenced this pull request Mar 28, 2023
deps: V8: cherry-pick 3e4952cb2a59
ca5c602 
Original commit message:

    [test] fix uninitialized error

    In op1a.Equals(&op3) call, that->parameter() is undefined.
    which triggers uninitialized error from gcc.

    Change-Id: I87f1fcba3e57adbb5a1e745a3d787c62a87fd1d3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4307714
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#86267}

Refs: v8/v8@3e4952c
PR-URL: #47236
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

richardlau commented Mar 28, 2023

Copy link
Copy Markdown
Member Author

Landed in ca5c602.

richardlau closed this Mar 28, 2023
richardlau deleted the gcc-10 branch March 28, 2023 14:54
RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
deps: V8: cherry-pick 3e4952cb2a59
70e2839 
Original commit message:

    [test] fix uninitialized error

    In op1a.Equals(&op3) call, that->parameter() is undefined.
    which triggers uninitialized error from gcc.

    Change-Id: I87f1fcba3e57adbb5a1e745a3d787c62a87fd1d3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4307714
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#86267}

Refs: v8/v8@3e4952c
PR-URL: #47236
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
deps: V8: cherry-pick 3e4952cb2a59
38c918c 
Original commit message:

    [test] fix uninitialized error

    In op1a.Equals(&op3) call, that->parameter() is undefined.
    which triggers uninitialized error from gcc.

    Change-Id: I87f1fcba3e57adbb5a1e745a3d787c62a87fd1d3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4307714
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#86267}

Refs: v8/v8@3e4952c
PR-URL: #47236
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
deps: V8: cherry-pick 3e4952cb2a59
06b7183 
Original commit message:

    [test] fix uninitialized error

    In op1a.Equals(&op3) call, that->parameter() is undefined.
    which triggers uninitialized error from gcc.

    Change-Id: I87f1fcba3e57adbb5a1e745a3d787c62a87fd1d3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4307714
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#86267}

Refs: v8/v8@3e4952c
PR-URL: #47236
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
deps: V8: cherry-pick 3e4952cb2a59
966ba28 
Original commit message:

    [test] fix uninitialized error

    In op1a.Equals(&op3) call, that->parameter() is undefined.
    which triggers uninitialized error from gcc.

    Change-Id: I87f1fcba3e57adbb5a1e745a3d787c62a87fd1d3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4307714
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#86267}

Refs: v8/v8@3e4952c
PR-URL: #47236
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gengjiawen gengjiawen approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL