FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: fix Slack notification action by aduh95 · Pull Request #47237 · nodejs/node · GitHub

/ node Public

tools: fix Slack notification action - #47237

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:notify-invalid-commit
Mar 23, 2023
Merged

tools: fix Slack notification action#47237
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:notify-invalid-commit

Conversation

aduh95 commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 23, 2023

aduh95 commented Mar 23, 2023

Copy link
Copy Markdown
Contributor Author

I tested it this time: aduh95/node-auto-test#1 (comment)

debadree25 commented Mar 23, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Should we fast-track this? adding the fast-track label for now, feel free to remove if deemed not ncessary

debadree25 added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 23, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @debadree25. Please 👍 to approve.

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 23, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 23, 2023
nodejs-github-bot merged commit 946f0ca into nodejs:main Mar 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 946f0ca

RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
PR-URL: #47237
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
RafaelGSS mentioned this pull request Apr 6, 2023
aduh95 deleted the notify-invalid-commit branch April 6, 2023 15:06
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
PR-URL: #47237
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47237
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL