FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update timezone to 2023b by nodejs-github-bot · Pull Request #47256 · nodejs/node · GitHub

/ node Public

deps: update timezone to 2023b - #47256

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/timezone-update
Mar 28, 2023
Merged

deps: update timezone to 2023b#47256
nodejs-github-bot merged 1 commit into
mainfrom
actions/timezone-update

Conversation

Copy link
Copy Markdown
Collaborator

This PR was generated by tools/timezone-update.yml.

Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data

To test, build node off this branch & log the version of tz using

console.log(process.versions.tz)

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Mar 26, 2023
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2023

Copy link
Copy Markdown
Collaborator Author

Copy link
Copy Markdown
Collaborator Author

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 26, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 28, 2023
nodejs-github-bot merged commit 67200dc into main Mar 28, 2023
nodejs-github-bot deleted the actions/timezone-update branch March 28, 2023 00:49

Copy link
Copy Markdown
Collaborator Author

Landed in 67200dc

targos mentioned this pull request Mar 28, 2023

Copy link
Copy Markdown
Member

cc @nodejs/releasers
So it seems that 2023b was for "Lebanon delays the start of DST this year": https://mm.icann.org/pipermail/tz-announce/2023-March/000078.html
However it sounds like this decision has been reversed, (there's a lot of chatter on https://mm.icann.org/pipermail/tz/2023-March/thread.html) and for now users should either stick to 2023a or wait for 2023c. https://mm.icann.org/pipermail/tz/2023-March/032833.html

Copy link
Copy Markdown
Member

Removing the backport-blocked labels as #47302 has fixed the incorrect timezone that this update included. The commit from this PR needs to land so that #47302 can land cleanly on the staging branches.

RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
PR-URL: #47256
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
PR-URL: #47256
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
PR-URL: #47256
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47256
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL