test: skip instantiateStreaming-bad-imports WPT - #47292
Conversation
Sorry, something went wrong.
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0.
|
/cc @nodejs/v8-update @nodejs/tsc |
Sorry, something went wrong.
MoLow
left a comment
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
|
Fast-track has been requested by @targos. Please 👍 to approve. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Is it flaky, or just out right failing/hanging to a point where you want to skip it everywhere? If just flaky, the flaky test names may just be added like so {
"instantiateStreaming-bad-imports.any.js": {
"fail": {
"note": "You may leave an optional arbitrary note e.g. with TODOs",
"flaky": [
"flaky test name"
]
}
}
}If it's hanging, we need to look into the running properly handling such cases. If you want to skip them on a particular build or configuration, there's no way to do that today, but we could revive #45826 (comment) to be able to do this type of skipping/flaky declaration. |
Sorry, something went wrong.
|
It is hanging but not 100% of the runs. Either it passes or it hangs. |
Sorry, something went wrong.
Let's skip then but open an issue to investigate why the runner can't deal with it. |
Sorry, something went wrong.
We can open a revert PR after landing V8 update on main. |
Sorry, something went wrong.
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47292 Refs: #46815 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47292 Refs: #46815 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47292 Refs: #46815 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This test is flaky on ARM with V8 >= 11.2. Skip it so we can update V8 before the release of Nodejs 20.0.0. PR-URL: #47292 Refs: #46815 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.
Refs: #46815 and #47251