FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: skip test-wasm-web-api on ARM by targos · Pull Request #47299 · nodejs/node · GitHub

/ node Public

test: skip test-wasm-web-api on ARM - #47299

Closed
targos wants to merge 1 commit into
nodejs:mainfrom
targos:wasm-web-api
ConversationCommits (1)ChecksFiles changed
Closed

test: skip test-wasm-web-api on ARM#47299
targos wants to merge 1 commit into
nodejs:mainfrom
targos:wasm-web-api

Conversation

targos commented Mar 29, 2023

Copy link
Copy Markdown
Member

This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

Refs: #47251

test: skip test-wasm-web-api on ARM
0931885 
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.
This was referenced Mar 29, 2023
Closed
Closed
targos added v8 engine Issues and PRs related to the V8 dependency. test Issues and PRs related to the tests. arm Issues and PRs related to the ARM architecture. wasm Issues and PRs related to WebAssembly. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 29, 2023

panva commented Mar 29, 2023

Copy link
Copy Markdown
Member

Fast-track has been requested by @targos. Please 👍 to approve.

panva commented Mar 29, 2023

Copy link
Copy Markdown
Member

(actions has degraded performance at this time so might take a while for the bot comment to appear, when it does, remove it as CQ looks at the last matching comment in the PR)

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2023
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 30, 2023

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/47299
✔  Done loading data for nodejs/node/pull/47299
----------------------------------- PR info ------------------------------------
Title      test: skip test-wasm-web-api on ARM (#47299)
Author     Michaël Zasso  (@targos)
Branch     targos:wasm-web-api -> nodejs:main
Labels     v8 engine, test, arm, fast-track, wasm
Commits    1
 - test: skip test-wasm-web-api on ARM
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/pull/47251
Reviewed-By: Filip Skokan 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/pull/47251
Reviewed-By: Filip Skokan 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 29 Mar 2023 15:30:45 GMT
   ✔  Approvals: 7
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363426574
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363467577
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363470733
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363548198
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363551730
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363700293
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363880905
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4561323427

targos added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 30, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50687/

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5257/

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5257/

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2023

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5259/

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2023
nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 30, 2023

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/47299
✔  Done loading data for nodejs/node/pull/47299
----------------------------------- PR info ------------------------------------
Title      test: skip test-wasm-web-api on ARM (#47299)
Author     Michaël Zasso  (@targos)
Branch     targos:wasm-web-api -> nodejs:main
Labels     v8 engine, test, arm, fast-track, wasm
Commits    1
 - test: skip test-wasm-web-api on ARM
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/pull/47251
Reviewed-By: Filip Skokan 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/pull/47251
Reviewed-By: Filip Skokan 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 29 Mar 2023 15:30:45 GMT
   ✔  Approvals: 7
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363426574
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363467577
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363470733
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363548198
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363551730
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363700293
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363880905
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-03-30T06:50:07Z: https://ci.nodejs.org/job/node-test-pull-request/50687/
- Querying data for job/node-test-pull-request/50687/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4563127960

targos commented Mar 30, 2023

Copy link
Copy Markdown
Member Author

Landed in 65b79ab

targos closed this Mar 30, 2023
targos added a commit that referenced this pull request Mar 30, 2023
test: skip test-wasm-web-api on ARM
65b79ab 
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47299
Refs: #47251
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos deleted the wasm-web-api branch March 30, 2023 10:10
RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
test: skip test-wasm-web-api on ARM
ab1eb52 
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47299
Refs: #47251
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
test: skip test-wasm-web-api on ARM
81ec3f3 
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47299
Refs: #47251
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
test: skip test-wasm-web-api on ARM
d341d03 
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47299
Refs: #47251
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
test: skip test-wasm-web-api on ARM
53d9eb5 
This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47299
Refs: #47251
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
richardlau added a commit to richardlau/node-1 that referenced this pull request Sep 29, 2023
test: update skip for moved test-wasm-web-api
e00fd22 
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: nodejs#49869
Refs: nodejs#47299
Refs: nodejs#47297
richardlau mentioned this pull request Sep 29, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request Sep 30, 2023
test: update skip for moved test-wasm-web-api
6c9625d 
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: #49869
Refs: #47299
Refs: #47297
PR-URL: #49958
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request Nov 11, 2023
test: update skip for moved test-wasm-web-api
01b0152 
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: #49869
Refs: #47299
Refs: #47297
PR-URL: #49958
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
test: update skip for moved test-wasm-web-api
ba272e1 
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: nodejs#49869
Refs: nodejs#47299
Refs: nodejs#47297
PR-URL: nodejs#49958
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
lpinca lpinca approved these changes
anonrig anonrig approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
gengjiawen gengjiawen approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

arm Issues and PRs related to the ARM architecture. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency. wasm Issues and PRs related to WebAssembly.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL