FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: lower URL.canParse runs by KhafraDev · Pull Request #47351 · nodejs/node · GitHub

/ node Public

benchmark: lower URL.canParse runs - #47351

Closed
KhafraDev wants to merge 1 commit into
nodejs:mainfrom
KhafraDev:canparse-lower-benchmark-n
ConversationCommits (1)ChecksFiles changed
Closed

benchmark: lower URL.canParse runs#47351
KhafraDev wants to merge 1 commit into
nodejs:mainfrom
KhafraDev:canparse-lower-benchmark-n

Conversation

KhafraDev commented Mar 31, 2023

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. url Issues and PRs related to the legacy built-in url module. labels Mar 31, 2023
anonrig added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 31, 2023

github-actions Bot commented Mar 31, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023

This comment was marked as outdated.

Sign in to view

anonrig commented Mar 31, 2023

Copy link
Copy Markdown
Member

Cancelled Jenkins jobs since it's not required. We can merge this when the Github CI is green.

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50771/

anonrig commented Mar 31, 2023

Copy link
Copy Markdown
Member

Landed on a346b97

anonrig closed this Mar 31, 2023
KhafraDev deleted the canparse-lower-benchmark-n branch March 31, 2023 23:17

richardlau commented Apr 1, 2023

Copy link
Copy Markdown
Member

Landed on a346b97

@anonrig This commit appears to be missing metadata.

Trott pushed a commit that referenced this pull request Apr 1, 2023
benchmark: lower URL.canParse runs
39a08ee 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott commented Apr 1, 2023

Copy link
Copy Markdown
Member

Landed on a346b97

@anonrig This commit appears to be missing metadata.

I ran git node metadata 47351, pasted the resulting metadata into git amend, ran core-validate-commit to make sure all was well, and force-pushed to fix.

anonrig commented Apr 1, 2023

Copy link
Copy Markdown
Member

Thank you @Trott and @richardlau

This was referenced Apr 2, 2023
Open
Open
RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
benchmark: lower URL.canParse runs
97eb796 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
benchmark: lower URL.canParse runs
8a8a40c 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
benchmark: lower URL.canParse runs
48f6a67 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
benchmark: lower URL.canParse runs
6a4076a 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
benchmark: lower URL.canParse runs
a72780e 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MoLow commented Jul 6, 2023

Copy link
Copy Markdown
Member

@danielleadams this was accidentally pushed to v18.x-staging - a72780e but is blocked by #47179

MoLow mentioned this pull request Jul 6, 2023
Merged
targos pushed a commit that referenced this pull request Nov 10, 2023
benchmark: lower URL.canParse runs
3d7734c 
PR-URL: #47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
benchmark: lower URL.canParse runs
5c6a735 
PR-URL: nodejs/node#47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
benchmark: lower URL.canParse runs
f69376e 
PR-URL: nodejs/node#47351
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
jasnell jasnell approved these changes
anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. fast-track PRs that do not need to wait for 48 hours to land. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL