FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: display dot report as wide as the terminal width by rluvaton · Pull Request #47901 · nodejs/node · GitHub

/ node Public

test: display dot report as wide as the terminal width - #47901

Closed
rluvaton wants to merge 4 commits into
nodejs:mainfrom
rluvaton:display-dot-as-wide-as-the-terminal
Closed

test: display dot report as wide as the terminal width#47901
rluvaton wants to merge 4 commits into
nodejs:mainfrom
rluvaton:display-dot-as-wide-as-the-terminal

Conversation

rluvaton commented May 6, 2023
edited
Loading

Copy link
Copy Markdown
Member

How would you suggest I add a test for this?, I'm trying to avoid overridden process.stdout.columns

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 6, 2023

MoLow commented May 7, 2023

Copy link
Copy Markdown
Member

commit messages prefix should be test_runner:, not test:, besides that - maybe add a pseudo-tty test?

Copy link
Copy Markdown
Member Author

Closed in favor of #48038

rluvaton closed this May 16, 2023
rluvaton deleted the display-dot-as-wide-as-the-terminal branch May 16, 2023 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL