FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: display dot report as wide as the terminal width by rluvaton · Pull Request #48038 · nodejs/node · GitHub

/ node Public

test_runner: display dot report as wide as the terminal width - #48038

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
rluvaton:display-dot-test-report-as-wide-as-the-terminal
May 23, 2023
ConversationCommits (6)ChecksFiles changed
Merged

test_runner: display dot report as wide as the terminal width#48038
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
rluvaton:display-dot-test-report-as-wide-as-the-terminal

Conversation

rluvaton commented May 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I had a problem with PR #47901 so recreating it

nodejs-github-bot commented May 16, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 16, 2023
rluvaton mentioned this pull request May 16, 2023
Closed
MoLow reviewed May 19, 2023
View reviewed changes
Comment thread lib/internal/test_runner/reporter/dot.js Outdated
MoLow reviewed May 19, 2023
View reviewed changes
Comment thread lib/internal/test_runner/reporter/dot.js Outdated
Update lib/internal/test_runner/reporter/dot.js
ae1906c 
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
MoLow added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 19, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2023

nodejs-github-bot commented May 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51876/

nodejs-github-bot commented May 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51878/

github-actions Bot mentioned this pull request May 20, 2023
Open
19 tasks
Update test/fixtures/test-runner/output/dot_output_custom_columns.js
b991fd2 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
github-actions Bot mentioned this pull request May 21, 2023
Open
19 tasks
MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2023

nodejs-github-bot commented May 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51898/

nodejs-github-bot commented May 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51899/

cjihrig reviewed May 21, 2023
View reviewed changes
Comment thread lib/internal/test_runner/reporter/dot.js
yield 'X';
}
if ((type === 'test:fail' || type === 'test:pass') && ++count % 20 === 0) {
if ((type === 'test:fail' || type === 'test:pass') && ++count === columns) {

cjihrig May 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could the ++count === columns be nested inside of the top level if? That way we only need to call getLineLength() once from there.

rluvaton May 22, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The need to call again is in case of resize of the terminal

Comment thread test/fixtures/test-runner/output/dot_output_custom_columns.js Outdated
Comment thread test/fixtures/test-runner/output/dot_output_custom_columns.js Outdated
github-actions Bot mentioned this pull request May 22, 2023
Open
16 tasks
MoLow requested a review from cjihrig May 22, 2023 15:51
MoLow added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 22, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2023

nodejs-github-bot commented May 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51917/

github-actions Bot mentioned this pull request May 23, 2023
Open
22 tasks

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51919/

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
nodejs-github-bot merged commit 7e0c12f into nodejs:main May 23, 2023

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7e0c12f

This was referenced May 24, 2023
Open
Open
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request May 30, 2023
test_runner: display dot report as wide as the terminal width
23d310b 
PR-URL: #48038
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
github-actions Bot mentioned this pull request May 31, 2023
Open
22 tasks
targos mentioned this pull request Jun 4, 2023
Merged
rluvaton deleted the display-dot-test-report-as-wide-as-the-terminal branch June 28, 2023 17:40
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
test_runner: display dot report as wide as the terminal width
f8cf353 
PR-URL: #48038
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
test_runner: display dot report as wide as the terminal width
e0d0b19 
PR-URL: nodejs#48038
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test_runner: display dot report as wide as the terminal width
7af4903 
PR-URL: nodejs#48038
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test_runner: display dot report as wide as the terminal width
ac4359d 
PR-URL: nodejs#48038
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
cjihrig cjihrig approved these changes
MoLow MoLow approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL