node-api: make napi_ref for all value types to be experimental - #47975
Closed
vmoroz wants to merge 5 commits into
Closed
node-api: make napi_ref for all value types to be experimental#47975vmoroz wants to merge 5 commits into
vmoroz wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
gabrielschulhof
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
One minor doc request, otherwise LGTM.
Sorry, something went wrong.
Comment thread
doc/api/n-api.md
Outdated
toyobayashi
added a commit
to toyobayashi/emnapi
that referenced
this pull request
May 13, 2023
Comment thread
doc/api/n-api.md
Outdated
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
legendecas
approved these changes
May 16, 2023
mhdawson
approved these changes
May 16, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Comment thread
doc/api/n-api.md
Outdated
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47975 ✔ Done loading data for nodejs/node/pull/47975 ----------------------------------- PR info ------------------------------------ Title node-api: make `napi_ref` for all value types to be experimental (#47975) Author Vladimir Morozov (@vmoroz) Branch vmoroz:PR/napi_ref_all_values_experimental -> nodejs:main Labels c++, node-api, needs-ci Commits 5 - node-api: napi_ref for all value types is experimental - extract experimental behavior into a paragraph - update doc/api/n-api.md - fix lint-md issues - update doc/api/n-api.md Committers 2 - Vladimir Morozov - GitHub PR-URL: https://github.com/nodejs/node/pull/47975 Reviewed-By: Chengzhong Wu Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47975 Reviewed-By: Chengzhong Wu Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - update doc/api/n-api.md ℹ This PR was created on Fri, 12 May 2023 14:21:41 GMT ✔ Approvals: 2 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/47975#pullrequestreview-1428929792 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47975#pullrequestreview-1429103385 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-05-16T17:58:27Z: https://ci.nodejs.org/job/node-test-pull-request/51830/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - update doc/api/n-api.md - Querying data for job/node-test-pull-request/51830/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5014193886 |
Sorry, something went wrong.
mhdawson
pushed a commit
that referenced
this pull request
May 18, 2023
PR-URL: #47975 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2023
PR-URL: #47975 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47975 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47975 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #45715 implemented a new versioning mechanism for Node-API module behavior, and it also introduced a new behavior for napi_ref to accept all value types. Since we are about to create new Node-API version 9, it was decided that the napi_ref for all value types did not have enough "baking period" and it must remain in the experimental status for a while.
In this PR we change the condition when the napi_ref is available for all types - it must be when the module targets NAPI_VERSION_EXPERIMENTAL version. The Node-API documentation is also changed to reflect the experimental status of this napi_refbehavioral change.