node-api: add status napi_cannot_run_js - #47986
Closed
gabrielschulhof wants to merge 9 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
gabrielschulhof
force-pushed
the
cannot-call-into-js-status
branch
from
b2fd523 to
a843857
Compare
May 13, 2023 08:26
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code.
gabrielschulhof
force-pushed
the
cannot-call-into-js-status
branch
from
a843857 to
0e89301
Compare
May 13, 2023 08:37
gabrielschulhof
commented
May 16, 2023
Comment thread
doc/api/n-api.md
Outdated
legendecas
reviewed
May 16, 2023
Comment thread
test/node-api/test_cannot_run_js/test.js
Outdated
Comment thread
test/node-api/test_cannot_run_js/binding.gyp
Outdated
Comment thread
test/node-api/test_cannot_run_js/test_cannot_run_js.c
Outdated
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
@legendecas I have addressed your review comments. Please take another look! |
Sorry, something went wrong.
legendecas
approved these changes
May 19, 2023
legendecas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM % nits.
Sorry, something went wrong.
Comment thread
test/js-native-api/test_cannot_run_js/test.js
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Some platforms do not seem to support target_defaults.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gabrielschulhof
added a commit
that referenced
this pull request
May 20, 2023
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code. PR-URL: #47986 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
16 tasks
This was referenced May 23, 2023
21 tasks
kvakil
added a commit
to kvakil/node
that referenced
this pull request
May 25, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576
This was referenced May 26, 2023
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 27, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: #48180 Refs: #47986 Refs: nodejs/reliability#576 PR-URL: #48181 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
20 tasks
targos
pushed a commit
that referenced
this pull request
May 30, 2023
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code. PR-URL: #47986 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: #48180 Refs: #47986 Refs: nodejs/reliability#576 PR-URL: #48181 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced Jun 21, 2023
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code. PR-URL: #47986 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: #48180 Refs: #47986 Refs: nodejs/reliability#576 PR-URL: #48181 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code. PR-URL: nodejs#47986 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576 PR-URL: nodejs#48181 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576 PR-URL: nodejs#48181 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
This test has been failing occasionally since it was introduced ~5 days ago. It was the most common failing JS test in the most recent reliability report. Mark it as flaky. Fixes: nodejs#48180 Refs: nodejs#47986 Refs: nodejs/reliability#576 PR-URL: nodejs#48181 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the new status in order to distinguish a state wherein an exception is pending from one wherein the engine is unable to execute JS. We take advantage of the new runtime add-on version reporting in order to remain forward compatible with add-ons that do not expect the new status code.