FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test_cannot_run_js as flaky by kvakil · Pull Request #48181 · nodejs/node · GitHub

/ node Public

test: mark test_cannot_run_js as flaky - #48181

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kvakil:skip-flake
May 27, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: mark test_cannot_run_js as flaky#48181
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kvakil:skip-flake

Conversation

kvakil commented May 25, 2023

Copy link
Copy Markdown
Contributor

This test has been failing occasionally since it was introduced ~5 days ago. It was the number one failing JS test in the most recent reliability report. Mark it as flaky.

Fixes: #48180
Refs: #47986
Refs: nodejs/reliability#576

test: mark test_cannot_run_js as flaky
6ee8586 
This test has been failing occasionally since it was introduced ~5 days
ago. It was the most common failing JS test in the most recent
reliability report. Mark it as flaky.

Fixes: nodejs#48180
Refs: nodejs#47986
Refs: nodejs/reliability#576
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 25, 2023
kvakil added the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2023

nodejs-github-bot commented May 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51967/

legendecas added flaky-test Issues and PRs related to the tests with unstable failures on the CI. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 26, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2023

nodejs-github-bot commented May 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51969/

legendecas added the node-api Issues and PRs related to the Node-API. label May 26, 2023
mhdawson approved these changes May 26, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson commented May 26, 2023

Copy link
Copy Markdown
Member

@gabrielschulhof just wondering if you added the test and if so can you take a look at why it might be flaky.

Agree we should mark as flaky while its investigate.

nodejs-github-bot commented May 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51974/

github-actions Bot mentioned this pull request May 27, 2023
Open
19 tasks
kvakil added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels May 27, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 27, 2023
nodejs-github-bot merged commit 186307a into nodejs:main May 27, 2023

nodejs-github-bot commented May 27, 2023

Copy link
Copy Markdown
Collaborator

Landed in 186307a

This was referenced May 28, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request May 30, 2023
test: mark test_cannot_run_js as flaky
c1c4796 
This test has been failing occasionally since it was introduced ~5 days
ago. It was the most common failing JS test in the most recent
reliability report. Mark it as flaky.

Fixes: #48180
Refs: #47986
Refs: nodejs/reliability#576
PR-URL: #48181
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced May 31, 2023
Open
Open
github-actions Bot mentioned this pull request Jun 3, 2023
Open
33 tasks
targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
test: mark test_cannot_run_js as flaky
34b611f 
This test has been failing occasionally since it was introduced ~5 days
ago. It was the most common failing JS test in the most recent
reliability report. Mark it as flaky.

Fixes: #48180
Refs: #47986
Refs: nodejs/reliability#576
PR-URL: #48181
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
test: mark test_cannot_run_js as flaky
1847669 
This test has been failing occasionally since it was introduced ~5 days
ago. It was the most common failing JS test in the most recent
reliability report. Mark it as flaky.

Fixes: nodejs#48180
Refs: nodejs#47986
Refs: nodejs/reliability#576
PR-URL: nodejs#48181
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: mark test_cannot_run_js as flaky
904ac33 
This test has been failing occasionally since it was introduced ~5 days
ago. It was the most common failing JS test in the most recent
reliability report. Mark it as flaky.

Fixes: nodejs#48180
Refs: nodejs#47986
Refs: nodejs/reliability#576
PR-URL: nodejs#48181
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: mark test_cannot_run_js as flaky
6dda2b1 
This test has been failing occasionally since it was introduced ~5 days
ago. It was the most common failing JS test in the most recent
reliability report. Mark it as flaky.

Fixes: nodejs#48180
Refs: nodejs#47986
Refs: nodejs/reliability#576
PR-URL: nodejs#48181
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau mentioned this pull request Feb 26, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

legendecas legendecas approved these changes
gabrielschulhof Awaiting requested review from gabrielschulhof
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky js-native-api/test_cannot_run_js/test

4 participants

Back | FazBrowse Home | New Git URL