FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: add enqueue and dequeue events by MoLow · Pull Request #48428 · nodejs/node · GitHub

/ node Public

test_runner: add enqueue and dequeue events - #48428

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:enque-deque
Jun 13, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test_runner: add enqueue and dequeue events#48428
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:enque-deque

Conversation

MoLow commented Jun 11, 2023

Copy link
Copy Markdown
Member

Fixes #46727

nodejs-github-bot commented Jun 11, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jun 11, 2023

MoLow commented Jun 11, 2023

Copy link
Copy Markdown
Member Author

@sankalp1999 FWIW, if you want to complete the work on #47797 I will close this PR

MoLow mentioned this pull request Jun 11, 2023
Closed
VoltrexKeyva reviewed Jun 11, 2023
View reviewed changes
Comment thread doc/api/test.md Outdated

sankalp1999 commented Jun 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@MoLow sorry, I couldn't find the time. I think you can continue with this one. I will close my PR. Thank you for reviewing.

anonrig reviewed Jun 11, 2023
View reviewed changes
Comment thread doc/api/test.md Outdated

anonrig Jun 11, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit

Suggested change
* `nesting` {number} The nesting level of the test.
* `level` {number} The nesting level of the test.

MoLow Jun 12, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nesting is already used on all other events on this class

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 12, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 12, 2023

nodejs-github-bot commented Jun 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52218/

nodejs-github-bot commented Jun 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52223/

MoLow added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 12, 2023
benjamingr reviewed Jun 12, 2023
View reviewed changes
Comment thread doc/api/test.md

* `data` {Object}
* `file` {string|undefined} The path of the test file,
undefined if test is not ran through a file.

benjamingr Jun 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
undefined if test is not ran through a file.
undefined if test was not run through a file.

MoLow Jun 13, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this exact terminology is used in 6 other places in this file, so I will fix it in a follow-up PR

benjamingr reviewed Jun 12, 2023
View reviewed changes
Comment thread doc/api/test.md

* `data` {Object}
* `file` {string|undefined} The path of the test file,
undefined if test is not ran through a file.

benjamingr Jun 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What are you trying to say here?

"will not run" in this (and above) perhaps?

MoLow Jun 13, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think running within REPL is the main example of this. Il refine this in a follow-up

benjamingr reviewed Jun 12, 2023
View reviewed changes
Comment thread test/parallel/test-runner-reporters.js
@@ -97,7 +97,7 @@ describe('node:test reporters', { concurrency: true }, () => {
testFile]);

benjamingr Jun 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would be useful to also test the arguments

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2023
nodejs-github-bot merged commit 8bc6e19 into nodejs:main Jun 13, 2023

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8bc6e19

MoLow deleted the enque-deque branch June 13, 2023 18:39
MoLow mentioned this pull request Jun 13, 2023
Merged
github-actions Bot mentioned this pull request Jun 21, 2023
Open
29 tasks
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
test_runner: add enqueue and dequeue events
de4f14c 
PR-URL: #48428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS mentioned this pull request Jul 3, 2023
Merged
MoLow mentioned this pull request Jul 9, 2023
Closed
MoLow added a commit to MoLow/node that referenced this pull request Jul 9, 2023
test_runner: add enqueue and dequeue events
c8cd582 
PR-URL: nodejs#48428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
test_runner: add enqueue and dequeue events
5d910ca 
PR-URL: #48428
Backport-PR-URL: #48684
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams mentioned this pull request Jul 12, 2023
Merged
philnash mentioned this pull request Aug 2, 2023
Merged
7 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test_runner: add enqueue and dequeue events
7d6dd95 
PR-URL: nodejs#48428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test_runner: add enqueue and dequeue events
7d6edcf 
PR-URL: nodejs#48428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
anonrig anonrig left review comments
cjihrig cjihrig approved these changes
+1 more reviewer
VoltrexKeyva VoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Indicate when a test is started in test_runner

8 participants

Back | FazBrowse Home | New Git URL